Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterating on the inserter for mobile #2691

Closed
karmatosed opened this issue Sep 7, 2017 · 5 comments
Closed

Iterating on the inserter for mobile #2691

karmatosed opened this issue Sep 7, 2017 · 5 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Mobile Web Viewport sizes for mobile and tablet devices
Milestone

Comments

@karmatosed
Copy link
Member

We have a lot of similar issues, all around improving the inserter for mobile. Having one issue we can focus on will help get this solved.

The mobile experience for inserting right now has a number of issues and one solution is to reduce this to a single inserter. There are a number of tickets to reflect on for this:

(Note: closing those tickets to focus here)

Technical issues around this are summarised [here] by @aduth (#2602 (comment)):

It's a tricky problem to solve because the Popover component has built-in logic to try to flip itself when exceeding bounds, but doesn't yet have the ability to know how to handle the case where there is no suitable position to open.

In my mind, I'm thinking one or more of:

The inserter menu probably shouldn't have offset 100vh height for the content inserter
If we encounter the case where no suitable position exists, we should at least set a max height/width of the popover to ensure it doesn't go offscreen, then allow remaining content to be scrollable
Edit: Another, perhaps more preferable option, is to treat the inserter as a full-page modal in mobile contexts, not "attached" to the specific anchor node.

Ultimately, we need a solution that solves all these issues. My thoughts are a single inserter is the way to go. I would recommend it being the top one, but discussion and ideas are important around this. We are not going to get far in mobile testing without this being fixed.

@karmatosed karmatosed added Needs Design Needs design efforts. [Feature] Inserter The main way to insert blocks using the + button in the editing interface Mobile Web Viewport sizes for mobile and tablet devices labels Sep 7, 2017
@karmatosed karmatosed added Design and removed Needs Design Needs design efforts. labels Sep 7, 2017
@karmatosed karmatosed added this to the Beta, Needs to happen milestone Sep 7, 2017
@karmatosed karmatosed self-assigned this Sep 24, 2017
@karmatosed karmatosed removed their assignment Oct 2, 2017
@ellatrix
Copy link
Member

ellatrix commented Oct 3, 2017

High priority for mobile xp imo. Gutenberg is not very useful without it.

@ellatrix
Copy link
Member

ellatrix commented Oct 3, 2017

Here's another: #2577.

@hedgefield
Copy link

The Inserter is indeed still very broken.

The sidebar works quite well on mobile, one option could be to apply that same look on the inserter. I think a lot of the weirdness it displays right now is because it's (incorrectly) figuring out which way to render towards. If we take that away and always have it take over the whole screen, that seems better already.

Are there any PRs or examinations being done on this already? As 1.7 was slated as the mobile UX update.

inserter

@afercia
Copy link
Contributor

afercia commented Nov 8, 2017

always have it take over the whole screen,

I'd agree that on small screens all the popup/modals and similar should be "full screen": take the max available space and no need to calculate positions.

@mtias
Copy link
Member

mtias commented Nov 29, 2017

Closing as full-screen popovers cover the main goal. Let's open specific issues for any other changes.

@mtias mtias closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Mobile Web Viewport sizes for mobile and tablet devices
Projects
None yet
Development

No branches or pull requests

5 participants