Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot insert new blocks in iOS Safari #2602

Closed
ellatrix opened this issue Aug 30, 2017 · 4 comments
Closed

Cannot insert new blocks in iOS Safari #2602

ellatrix opened this issue Aug 30, 2017 · 4 comments

Comments

@ellatrix
Copy link
Member

When I select a block, scroll up a bit to get the plus icon, and click it, the inserted appears in a strange location. Most of it is hidden. When I try to scroll to get to the rest, it scrolls a lot slower compared to the rest of the screen, and I never really get anywhere before I hit the top of the page. It also seems that most of it is clipped off by the page boundaries.

img_0481

@ellatrix
Copy link
Member Author

It sometimes appears in a different place:

img_0482

@aduth
Copy link
Member

aduth commented Aug 30, 2017

Duplicate of #2471

It's a tricky problem to solve because the Popover component has built-in logic to try to flip itself when exceeding bounds, but doesn't yet have the ability to know how to handle the case where there is no suitable position to open.

In my mind, I'm thinking one or more of:

  • The inserter menu probably shouldn't have offset 100vh height for the content inserter
  • If we encounter the case where no suitable position exists, we should at least set a max height/width of the popover to ensure it doesn't go offscreen, then allow remaining content to be scrollable

Edit: Another, perhaps more preferable option, is to treat the inserter as a full-page modal in mobile contexts, not "attached" to the specific anchor node.

@BE-Webdesign
Copy link
Contributor

Edit: Another, perhaps more preferable option, is to treat the inserter as a full-page modal in mobile contexts, not "attached" to the specific anchor node.

☝️

👍

@karmatosed
Copy link
Member

karmatosed commented Sep 7, 2017

We now have a single place to include all issues for mobile inserter in #2691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants