Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter triangle is misaligned #10453

Closed
tofumatt opened this issue Oct 9, 2018 · 3 comments · Fixed by #10461
Closed

Inserter triangle is misaligned #10453

tofumatt opened this issue Oct 9, 2018 · 3 comments · Fixed by #10461
Assignees
@tofumatt
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Milestone
4.0

Comments

@tofumatt
Copy link
Member

tofumatt commented Oct 9, 2018

Describe the bug
The triangle that connects the block inserter selection to the "Add Block +" button is disconnected from the block.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Add New Post"
  2. Click on "Add block (+)" on the left of the empty block
  3. Observe the disconnect!

Expected behavior
It's connected.

Screenshots
screenshot 2018-10-09 21 13 22
screenshot 2018-10-09 20 52 41

Additional context
Tested in Chrome and Firefox on master; probably happens elsewhere too.
@tofumatt tofumatt added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention User Experience (UX) labels Oct 9, 2018
@tofumatt tofumatt added this to the 4.0 milestone Oct 9, 2018
@chrisvanpatten
Copy link
Contributor

I've been wondering about this one 🤔

If I had to guess, #10295 is a likely candidate for the regression.

@chrisvanpatten
Copy link
Contributor

Update: yep, just confirmed it's definitely #10295 / f1d4fcb.

@tofumatt
Copy link
Member Author

tofumatt commented Oct 9, 2018

OMG, so it's my fault! How did I miss that?! 😓

Okay, I'll get that either fixed or reverted tonight, thanks for the digging! 👍

@tofumatt tofumatt self-assigned this Oct 9, 2018
@tofumatt tofumatt mentioned this issue Oct 10, 2018
Merged
tofumatt added a commit that referenced this issue Oct 10, 2018
@tofumatt
fix: Fix inserter misalignment regression
610cf99 
Fix #10453
tofumatt added a commit that referenced this issue Oct 10, 2018
@tofumatt
fix: Fix inserter misalignment regression (#10461)
49ed442 
* fix: Fix inserter misalignment regression

Fix #10453

* Use better margin

* Use 24px again!
@snyk-bot snyk-bot mentioned this issue Jul 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

fix: Fix inserter misalignment regression WordPress/gutenberg
2 participants
@tofumatt @chrisvanpatten