Skip to content

Commit

Permalink
Edit Post: Fix Welcome Guide modal display for Internet Explorer (#19201
Browse files Browse the repository at this point in the history
)

* Components: Remove guide contents centering

Doesn't appear to be needed, and causes overflow issues in IE due to Flexbox bug

See: https://github.com/philipwalton/flexbugs#flexbug-2

* Components: Use explicit display for guide finish button

* Components: Ensure modal is styled as positioned element

* Edit Post: Vertically center welcome guide image
  • Loading branch information
aduth authored Dec 18, 2019
1 parent 67cb1cc commit 5957797
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
3 changes: 1 addition & 2 deletions packages/components/src/guide/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
}

&__container {
align-items: center;
display: flex;
flex-direction: column;
margin-top: -$header-height;
Expand Down Expand Up @@ -107,7 +106,7 @@
right: 0;

@include break-small() {
display: unset;
display: block;
}
}

Expand Down
6 changes: 5 additions & 1 deletion packages/components/src/modal/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,13 @@
background: $white;
align-items: center;
height: $header-height;
z-index: z-index(".components-modal__header");
// For z-index to take effect, the element must be positioned. A "sticky"
// element is positioned, but since this is not supported in IE11,
// "relative" is used as a fallback.
position: relative;
position: sticky;
top: 0;
z-index: z-index(".components-modal__header");
margin: 0 -#{$grid-size-xlarge} $grid-size-xlarge;

// Rules inside this query are only run by Microsoft Edge.
Expand Down
6 changes: 4 additions & 2 deletions packages/edit-post/src/components/welcome-guide/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@
margin: $grid-size 0;

@include break-small() {
height: $image-height;
left: 0;
position: absolute;
left: 0;
top: 50%;
height: $image-height;
width: $image-width;
margin-top: -0.5 * $image-height;
}
}

Expand Down

0 comments on commit 5957797

Please sign in to comment.