Accessibility: don't tab to block drag handle (#19211)

* Accessibility: don't tab to block drag handle * Adjust e2e tests
WordPress · Dec 18, 2019 · 67cb1cc · 67cb1cc
1 parent 77a18d8
commit 67cb1cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/block-editor/src/components/block-mover/index.js b/packages/block-editor/src/components/block-mover/index.js
@@ -105,6 +105,9 @@ export class BlockMover extends Component {
 							icon={ dragHandle }
 							className="block-editor-block-mover__control-drag-handle block-editor-block-mover__control"
 							aria-hidden="true"
+							// Should not be able to tab to drag handle as this
+							// button can only be used with a pointer device.
+							tabIndex="-1"
 							onDragStart={ onDraggableStart }
 							onDragEnd={ onDraggableEnd }
 							draggable

diff --git a/packages/e2e-tests/specs/editor/various/keyboard-navigable-blocks.test.js b/packages/e2e-tests/specs/editor/various/keyboard-navigable-blocks.test.js
@@ -58,9 +58,6 @@ const tabThroughBlockMoverControl = async () => {
 	);
 	await expect( isFocusedMoveUpControl ).toBe( true );
 
-	// Tab to focus the drag handle
-	await page.keyboard.press( 'Tab' );
-
 	// Tab to focus on the 'move down' control
 	await page.keyboard.press( 'Tab' );
 	const isFocusedMoveDownControl = await page.evaluate( () =>