Core: add sniffs to check the formatting of ::class class resolution
#2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> 1. There should be no space between `::class` and the preceding class name it applies to. > 2. There should be no space between the double colon and the `class` keyword. > 3. The `class` keyword should be in lowercase. The first two rules are covered via the new `WordPress.WhiteSpace.ObjectOperatorSpacing` sniff. The last rule via a new sniff from PHPCSExtra. Refs: * https://make.wordpress.org/core/2020/03/20/updating-the-coding-standards-for-modern-php/ - `::class` constant section * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#magic-constants * WordPress/wpcs-docs 113 * WordPress/WordPress-Coding-Standards 1115 * WordPress/WordPress-Coding-Standards 1116 * WordPress/WordPress-Coding-Standards 2095 * PHPCSStandards/PHPCSExtra 72
dingo-d
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two rules are covered via the new
WordPress.WhiteSpace.ObjectOperatorSpacingsniff. The last rule via a new sniff from PHPCSExtra.Refs:
::classconstant sectionWordPress.WhiteSpace.ObjectOperatorSpacingsniff #2095Universal.Constants.LowercaseClassResolutionKeywordsniff PHPCSStandards/PHPCSExtra#72