✨ New WordPress.WhiteSpace.ObjectOperatorSpacing sniff
#2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sniff largely defers to the upstream `Squiz.WhiteSpace.ObjectOperatorSpacing` sniff, which was previously already included. The only real difference between the two sniffs is that for class resolution using `ClassName::class`, new lines around the `::` object operator will not be ignored. The WPCS sniff has the same default property settings as the upstream sniff and changes to the property values should be made in the ruleset. Includes docs. Includes unit tests covering the difference and safeguarding that the sniff doesn't overreach.
|
Note: there will be a follow-up PR to address the rest of that handbook section once PHPCSExtra 1.0.0-alpha4 has been tagged. |
dingo-d
approved these changes
Oct 27, 2022
GaryJones
deleted the
feature/new-wordpress-objectoperatorspacing-sniff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sniff largely defers to the upstream
Squiz.WhiteSpace.ObjectOperatorSpacingsniff, which was previously already included.The only real difference between the two sniffs is that for class resolution using
ClassName::class, new lines around the::object operator will not be ignored.The WPCS sniff has the same default property settings as the upstream sniff and changes to the property values should be made in the ruleset.
Includes docs.
Includes unit tests covering the difference and safeguarding that the sniff doesn't overreach.
Related to: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#magic-constants