PHPCS 3.x compat: remove php 5.2 work arounds and PHP 5.2 specific code #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
reviewed
Jul 25, 2017
| @@ -67,18 +61,7 @@ public function getErrorList( $testFile = 'PrefixAllGlobalsUnitTest.inc' ) { | |||
|
|
|||
| case 'PrefixAllGlobalsUnitTest.1.inc': | |||
There was a problem hiding this comment.
This case could simply fall through to the default. No need for a separate return array().
GaryJones
approved these changes
Jul 25, 2017
Includes removal of two secondary test case files which were a work-around for unrecognized syntaxes in PHP 5.2.
This should also allow the unit tests to pass against on PHP nightly.
jrfnl
force-pushed
the
WPCS-0.13.0/feature/remove-php-5.2-work-arounds
branch
from
69ba4bb to
15307be
Compare
|
FYI: now this PR is merged, the builds for PHP nightly will start to pass (were failing on a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the PHPCS 3.x compatibility PR series.
See the individual commits for more details. These have been set up for easy review.