PHPCS 3.x compat: remove work-arounds for compatibility with PHP 5.2

This should also allow the unit tests to pass against on PHP nightly.
WordPress · Jul 25, 2017 · 15307be · 15307be
1 parent ea76a40
commit 15307be
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/WordPress/Sniffs/VIP/ValidatedSanitizedInputSniff.php b/WordPress/Sniffs/VIP/ValidatedSanitizedInputSniff.php
@@ -95,7 +95,9 @@ public function process_token( $stackPtr ) {
 			|| T_HEREDOC === $this->tokens[ $stackPtr ]['code']
 		) {
 			$interpolated_variables = array_map(
-				create_function( '$symbol', 'return "$" . $symbol;' ), // Replace with closure when 5.3 is minimum requirement for PHPCS.
+				function ( $symbol ) {
+					return '$' . $symbol;
+				},
 				$this->get_interpolated_variables( $this->tokens[ $stackPtr ]['content'] )
 			);
 			foreach ( array_intersect( $interpolated_variables, $superglobals ) as $bad_variable ) {

diff --git a/WordPress/Sniffs/WP/PreparedSQLSniff.php b/WordPress/Sniffs/WP/PreparedSQLSniff.php
@@ -139,7 +139,9 @@ public function process_token( $stackPtr ) {
 
 				$bad_variables = array_filter(
 					$this->get_interpolated_variables( $this->tokens[ $this->i ]['content'] ),
-					create_function( '$symbol', 'return ( $symbol !== "wpdb" );' ) // Replace this with closure once 5.3 is minimum requirement.
+					function ( $symbol ) {
+						return ( 'wpdb' !== $symbol );
+					}
 				);
 
 				foreach ( $bad_variables as $bad_variable ) {