Merge pull request #584 from jrfnl/feature/issue-460-vip-ini-set

Add two sections to the VIP.RestrictedFunctions sniff.

WordPress/Sniffs/VIP/RestrictedFunctionsSniff.php

@@ -318,6 +318,33 @@ public function getGroups() {
 				),
 			),
 
+			'runtime_configuration' => array(
+				'type' => 'error',
+				'message' => '%s is prohibited, changing configuration at runtime is not allowed on VIP Production.',
+				'functions' => array(
+					'dl',
+					'error_reporting',
+					'ini_alter',
+					'ini_restore',
+					'ini_set',
+					'magic_quotes_runtime',
+					'set_magic_quotes_runtime',
+					'apache_setenv',
+					'putenv',
+					'set_include_path',
+					'restore_include_path',
+				),
+			),
+
+			'prevent_path_disclosure' => array(
+				'type' => 'error',
+				'message' => '%s is prohibited as it can lead to full path disclosure.',
+				'functions' => array(
+					'error_reporting',
+					'phpinfo',
+				),
+			),
+
 		);
 	}
 }//end class

WordPress/Tests/VIP/RestrictedFunctionsUnitTest.inc

@@ -70,3 +70,16 @@ get_adjacent_post(); // error
 get_previous_post(); // error
 get_next_post(); // error
 parse_url( 'http://example.com/' ); // warning
+
+dl(); // error
+error_reporting(); // error
+ini_alter(); // error
+ini_restore(); // error
+ini_set(); // error
+magic_quotes_runtime(); // error
+set_magic_quotes_runtime(); // error
+apache_setenv(); // error
+putenv(); // error
+set_include_path(); // error
+restore_include_path(); // error
+phpinfo(); // error

WordPress/Tests/VIP/RestrictedFunctionsUnitTest.php

@@ -53,6 +53,18 @@ public function getErrorList()
             69 => 1,
             70 => 1,
             71 => 1,
+            74 => 1,
+            75 => 2,
+            76 => 1,
+            77 => 1,
+            78 => 1,
+            79 => 1,
+            80 => 1,
+            81 => 1,
+            82 => 1,
+            83 => 1,
+            84 => 1,
+            85 => 1,
         );
 
     }//end getErrorList()