Merge pull request #573 from davidpagepsycle/feature/revert-get-pages…

…-569

Remove `get_pages()` from uncached functions in …

WordPress/Sniffs/VIP/RestrictedFunctionsSniff.php

@@ -174,15 +174,7 @@ public function getGroups() {
 				'functions' => array(
 					'get_posts',
 					'wp_get_recent_posts',
-				),
-			),
-
-			'get_pages' => array(
-				'type' => 'error',
-				'message' => '%s is highly discouraged in favor of creating a new WP_Query() so that Advanced Post Cache will cache the query.',
-				'functions' => array(
 					'get_children',
-					'get_pages',
 				),
 			),
 

WordPress/Tests/VIP/RestrictedFunctionsUnitTest.inc

@@ -57,8 +57,8 @@ url_to_post_id(); // error
 attachment_url_to_postid(); // error
 get_posts(); // warning
 wp_get_recent_posts(); // warning
-get_pages(); // error
-get_children(); // error
+
+get_children(); // warning
 wp_get_post_terms(); // error
 wp_get_post_categories(); // error
 wp_get_post_tags(); // error

WordPress/Tests/VIP/RestrictedFunctionsUnitTest.php

@@ -43,8 +43,6 @@ public function getErrorList()
             55 => 1,
             56 => 1,
             57 => 1,
-            60 => 1,
-            61 => 1,
             62 => 1,
             63 => 1,
             64 => 1,
@@ -80,6 +78,7 @@ public function getWarningList()
             19 => 1,
             58 => 1,
             59 => 1,
+            61 => 1,
             72 => 1,
             );