Revert "[recorder] set 'hasReplay' to undefined by defaultb (DataDog#697

)" This reverts commit baf627a.
WonderInventions · Jan 29, 2021 · 265899d · 265899d
1 parent 5c9747d
commit 265899d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/rum-core/src/rawRumEvent.types.ts b/packages/rum-core/src/rawRumEvent.types.ts
@@ -176,5 +176,5 @@ export interface User {
 export interface CommonContext {
   user: User
   context: Context
-  hasReplay?: true
+  hasReplay?: boolean
 }
diff --git a/packages/rum-recorder/src/boot/rumRecorderPublicApi.spec.ts b/packages/rum-recorder/src/boot/rumRecorderPublicApi.spec.ts
@@ -70,7 +70,7 @@ describe('makeRumRecorderPublicApi', () => {
     it('if enabled, commonContext.hasReplay should be true only if startSessionRecord is called', () => {
       enabledFlags = ['postpone_start_recording']
       rumGlobal.init(DEFAULT_INIT_CONFIGURATION)
-      expect(getCommonContext().hasReplay).toBeUndefined()
+      expect(getCommonContext().hasReplay).toBe(false)
       rumGlobal.startSessionRecord!()
       expect(getCommonContext().hasReplay).toBe(true)
     })

diff --git a/packages/rum-recorder/src/boot/rumRecorderPublicApi.ts b/packages/rum-recorder/src/boot/rumRecorderPublicApi.ts
@@ -7,7 +7,7 @@ export type StartRecording = typeof startRecording
 
 export function makeRumRecorderPublicApi(startRumImpl: StartRum, startRecordingImpl: StartRecording) {
   const rumRecorderGlobal = makeRumPublicApi((userConfiguration, getCommonContext) => {
-    let isRecording: true | undefined
+    let isRecording = false
 
     const startRumResult = startRumImpl(userConfiguration, () => ({
       ...getCommonContext(),