[recorder] set 'hasReplay' to undefined by default #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only affects the recorder with flag `postpone_start_recording`. `session.has_replay` should not be set if the record has not been started, to be consistent with the RUM bundle without recorder.
BenoitZugmeyer
changed the title
ThibautGeriz
approved these changes
Jan 22, 2021
vlad-mh
approved these changes
Jan 22, 2021
BenoitZugmeyer
deleted the
benoit/set-is-recording-to-undefined-by-default
branch
kcaffrey
pushed a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
This change only affects the recorder with flag `postpone_start_recording`. `session.has_replay` should not be set if the record has not been started, to be consistent with the RUM bundle without recorder.
kcaffrey
added a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
)" This reverts commit baf627a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
session.has_replayshould not be set if the record has not been started, to be consistent with the RUM bundle without recorder.This change only affects the recorder with flag
postpone_start_recording.Changes
Set hasReplay to undefined by default.
Adjust typings to enforce this.
Testing
Unit
I have gone over the contributing documentation.