Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeViewer: AutoExpandTrivialPaths #2

Merged
merged 319 commits into from
Mar 8, 2024
Merged

Conversation

Wittmaxi
Copy link
Owner

This commit addresses the need to automatically expand paths which consist of chained singular nodes, eg:

com.wittmaxi.plugin
└─src
└─org.foo.com
└─Bar.java

It introduces four new API-Methods

-setAutoExpandTrivialPaths
-getAutoExpandTrivialPaths
-setAutoExpandTrivialPathsLevel
-getAutoExpandTrivialPathsLevel

@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch 8 times, most recently from 2486211 to 1a49af7 Compare August 30, 2023 15:16
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch 2 times, most recently from c049882 to ced49bd Compare September 18, 2023 08:07
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch from ced49bd to 87a47e2 Compare October 2, 2023 11:36
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch from 87a47e2 to 5c61e61 Compare October 2, 2023 12:46
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch from 5c61e61 to 8af421c Compare October 2, 2023 13:05
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch 2 times, most recently from 99adede to 393e4ce Compare October 12, 2023 09:22
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch from 393e4ce to c274821 Compare October 24, 2023 15:35
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch 4 times, most recently from 20f4821 to 549fd31 Compare November 11, 2023 09:38
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch 2 times, most recently from 41114eb to 6105478 Compare November 21, 2023 13:34
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch 6 times, most recently from ac700f4 to ae4bdb9 Compare November 28, 2023 15:50
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch from ae4bdb9 to 790a569 Compare November 29, 2023 16:16
@Wittmaxi Wittmaxi force-pushed the MW_treeviewer_autoexpand branch from 790a569 to 67e383c Compare December 5, 2023 11:33
Unlucky value range of System.nanoTime() could have prevented throttled
Runnable to run.
Also adapt column width to show most values without ellipsis
to return always the same string instance
Saves all duplicate Strings in
org.eclipse.e4.ui.css.swt.dom.WidgetElement.localName
…rm#1695

Avoids a 500ms delay after changing the selection, like higlighting the
selected word.

eclipse-platform#1695
StatusLine message is used both as ProgressMonitor and to show problems.

When a problem message is reset while ProgressMonitor is running the
progress message was lost.
When a ProgressMonitor finished while a problem was shown the problem
message was lost;

Happened for example while opening Quick-Type Hierarchy within <500ms
after selecting a line that had a Problem marker.
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch 3 times, most recently from 20e35ad to a9515b1 Compare March 5, 2024 20:00
Using the same pattern all over should avoid errors and make source
easier to understand.

pattern is:

```
int c = Primitive.compare(v1, v2)
if (c != 0) {
	return c;
}
... // next comparison
```
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch 2 times, most recently from 1c8a4e8 to 322ee21 Compare March 6, 2024 15:12
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch 2 times, most recently from bf0ce44 to 0eab3bd Compare March 7, 2024 15:00
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch from 0eab3bd to c4040b2 Compare March 7, 2024 15:28
jukzi and others added 6 commits March 7, 2024 22:10
Not fail build on failed test, to still show the ecj warnings if tests fail.
Copied from jdt
This commit addresses the need to automatically expand paths which
consist of chained singular nodes, eg:

com.wittmaxi.plugin
 └─src
    └─org.foo.com
       └─Bar.java

It introduces two new methods to the API of TreeViewer

-setAutoExpandOnSingleChildLevel
-getAutoExpandOnSingleChildLevel

Also includes a version bump for AbstractTreeViewer Autoexpand
Tests for virtual lazy tree viewers that access the data of a tree items
have been disabled because of some bug in according Mac implementation.
This also disables a test case for the auto-expand on single child
functionality that relies on accessing the item data.

Also removes unused API problem filters.
@HeikoKlare HeikoKlare force-pushed the MW_treeviewer_autoexpand branch from c4040b2 to 8e0452b Compare March 8, 2024 12:45
@Wittmaxi Wittmaxi merged commit b4cd057 into master Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.