Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParameterNamesCodeMiningTest fails on I Builds #1236

Closed
jukzi opened this issue Mar 7, 2024 · 4 comments
Closed

ParameterNamesCodeMiningTest fails on I Builds #1236

jukzi opened this issue Mar 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working regression Regression defect test junit test related things

Comments

@jukzi
Copy link
Contributor

jukzi commented Mar 7, 2024

on most platforms
for example https://download.eclipse.org/eclipse/downloads/drops4/I20240306-1800/testresults/html/org.eclipse.jdt.text.tests_ep432I-unit-cen64-gtk3-java21_linux.gtk.x86_64_21.html

java.lang.AssertionError: Occurence annotation not added

at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.eclipse.jdt.text.tests.codemining.ParameterNamesCodeMiningTest.testCollapsedFoldingAndToggleHighlight(ParameterNamesCodeMiningTest.java:272)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
@jukzi jukzi added bug Something isn't working regression Regression defect test junit test related things labels Mar 7, 2024
@iloveeclipse
Copy link
Member

This is a regression from eclipse-platform/eclipse.platform.ui#1703.

Please check whether the change or the test need to be fixed.

@jukzi jukzi self-assigned this Mar 7, 2024
@jukzi
Copy link
Contributor Author

jukzi commented Mar 7, 2024

I can reproduce it, but don't know yet how to fix. The firePostSelectionChanged is send (immediatly instead of after a delay ini this case), but somehow that does not work in this case. May be some concurrency issue that was just did show up yet. i will investigate.

@jukzi
Copy link
Contributor Author

jukzi commented Mar 7, 2024

to be fixed by eclipse-platform/eclipse.platform.ui#1738

@iloveeclipse
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Regression defect test junit test related things
Projects
None yet
Development

No branches or pull requests

2 participants