Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new setting: usetakefocus #1246

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Jun 4, 2019

As referenced on PhoenicisOrg/scripts#939 Unity-based wineapps like Magic: The Gathering arena (PhoenicisOrg/scripts#937) and Minion Masters (PhoenicisOrg/scripts#957) require registry change of HKEY_CURRENT_USER\Software\Wine\X11 Driver\UseTakeFocus to be set on value of N/Y accordingly to avoid wineapps from becaming unresponsible to user-input after focus change.

This commit should make it easier for everyone affected to fix the issue easily using winetricks.

Credit:

  • vanilline/Constantine for ukranian translate of function
  • Community of Learn Klingon for Tlhngan-Hol translate of function

Signed-off-by: Jacob Hrbek [email protected]

@austin987
Copy link
Contributor

If you can't make the translation, why worry about it? Lots of things are untranslated. And if you are worried about it, why only Ukrainian and not other languages?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 4, 2019

@austin987

If you can't make the translation, why worry about it? Lots of things are untranslated. And if you are worried about it, why only Ukrainian and not other languages?

Because every other setting has it and because of perfectionism assuming that we are in FOSS to afford making quality code :3

i was assuming that winetricks dev is russian based on only russian translate present? Was hoping {s,}he can translate it; else wait i make someone else translate it.

didn't know that it's ukranian

@austin987
Copy link
Contributor

I'm the maintainer, I don't speak Ukrainian or Russian ;). There are active contributors in a few languages that tend to keep things up to date, fwiw.

src/winetricks Outdated Show resolved Hide resolved
src/winetricks Show resolved Hide resolved
src/winetricks Show resolved Hide resolved
src/winetricks Show resolved Hide resolved
src/winetricks Outdated Show resolved Hide resolved
src/winetricks Show resolved Hide resolved
src/winetricks Show resolved Hide resolved
@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 4, 2019

@vanilline You are a native ukranian speaker correct?

@gavura256
Copy link

@vanilline You are a native ukranian speaker correct?

yes, and russian native speaker too

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 4, 2019

Contributors for translate credited in original message of MR, Added translate for cz,sk,tlh,uk

@Kreyren Kreyren marked this pull request as ready for review June 4, 2019 17:25
@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 4, 2019

Requesting approval of changes, do not merge yet since tlh might be improved.

EDIT: feel free to merge, tlh can be updated anytime and this is good enough.

EDIT2: Updated tlh translate with accurate translate. Since tlh doesn't have translate for default we decided to use which has not been changed conversation is present on https://www.facebook.com/groups/LearnKlingon/2272148659560004/?comment_id=2272175222890681&reply_comment_id=2273454989429371&notif_id=1559732136705884&notif_t=group_comment

@Kreyren Kreyren force-pushed the usetakefocus branch 2 times, most recently from 2fcd2cc to 5eaef61 Compare June 5, 2019 12:34
Signed-off-by: Jacob Hrbek <[email protected]>
@austin987
Copy link
Contributor

I don't see a need for Klingon, but easter eggs are fine, I guess :p

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 15, 2019

@austin987 Like i can remove it if you don't want that translate 🤔 i was more thinking about actuall usecase since my system is partially in this lang.

@austin987
Copy link
Contributor

It's fine. Is this okay to merge then?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 15, 2019

@austin987 yep feel free to merge.

@Chiitoo
Copy link
Collaborator

Chiitoo commented Jun 15, 2019

As a sidey-note, edits here do not reach people via e-mail... :]

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 15, 2019

@Chiitoo is winetricks beeing monitored via emails?

@Chiitoo
Copy link
Collaborator

Chiitoo commented Jun 15, 2019

Well, not sure how Austin does it exactly, but when you 'watch' a repository at GitHub, you get notifications, and some only use e-mail notifications, which are not sent when you edit a comment.

So what I would suggest to anyone using GitHub, is not using editing comments for updating things that have any importance since a lot of people won't notice them (I did not see your edits until the new comments came in, and I scrolled up after reading them).

It's not a good system on GitHub's part.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 15, 2019

@Chiitoo is noted

@austin987
Copy link
Contributor

Generally I get notifications via mail, then read on the website. edits (and force pushes) do not give notifications; for fixing PRs force pushes are good practice, a comment ensures people know about it.

@austin987 austin987 merged commit d0313e7 into Winetricks:master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants