-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new setting: usetakefocus #1246
Conversation
If you can't make the translation, why worry about it? Lots of things are untranslated. And if you are worried about it, why only Ukrainian and not other languages? |
Because every other setting has it and because of perfectionism assuming that we are in FOSS to afford making quality code :3 i was assuming that winetricks dev is russian based on only russian translate present? Was hoping {s,}he can translate it; else wait i make someone else translate it.
|
I'm the maintainer, I don't speak Ukrainian or Russian ;). There are active contributors in a few languages that tend to keep things up to date, fwiw. |
@vanilline You are a native ukranian speaker correct? |
yes, and russian native speaker too |
Contributors for translate credited in original message of MR, Added translate for cz,sk,tlh,uk |
Requesting approval of changes, do not merge yet since tlh might be improved. EDIT: feel free to merge, tlh can be updated anytime and this is good enough. EDIT2: Updated tlh translate with accurate translate. Since tlh doesn't have translate for |
2fcd2cc
to
5eaef61
Compare
Signed-off-by: Jacob Hrbek <[email protected]>
I don't see a need for Klingon, but easter eggs are fine, I guess :p |
@austin987 Like i can remove it if you don't want that translate 🤔 i was more thinking about actuall usecase since my system is partially in this lang. |
It's fine. Is this okay to merge then? |
@austin987 yep feel free to merge. |
As a sidey-note, edits here do not reach people via e-mail... :] |
@Chiitoo is winetricks beeing monitored via emails? |
Well, not sure how Austin does it exactly, but when you 'watch' a repository at GitHub, you get notifications, and some only use e-mail notifications, which are not sent when you edit a comment. So what I would suggest to anyone using GitHub, is not using editing comments for updating things that have any importance since a lot of people won't notice them (I did not see your edits until the new comments came in, and I scrolled up after reading them). It's not a good system on GitHub's part. |
@Chiitoo is noted |
Generally I get notifications via mail, then read on the website. edits (and force pushes) do not give notifications; for fixing PRs force pushes are good practice, a comment ensures people know about it. |
As referenced on PhoenicisOrg/scripts#939 Unity-based wineapps like Magic: The Gathering arena (PhoenicisOrg/scripts#937) and Minion Masters (PhoenicisOrg/scripts#957) require registry change of
HKEY_CURRENT_USER\Software\Wine\X11 Driver\UseTakeFocus
to be set on value ofN/Y
accordingly to avoid wineapps from becaming unresponsible to user-input after focus change.This commit should make it easier for everyone affected to fix the issue easily using winetricks.
Credit:
Signed-off-by: Jacob Hrbek [email protected]