Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Magic The Gathering Arena #937

Merged
merged 7 commits into from
May 19, 2019
Merged

Add Magic The Gathering Arena #937

merged 7 commits into from
May 19, 2019

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented May 11, 2019

Fixes: #934

Blocked by #936

@Kreyren Kreyren force-pushed the MTG branch 3 times, most recently from e40bd66 to 8f36a9b Compare May 13, 2019 13:44
Kreyren pushed a commit to Kreyrenicis/compatibilators that referenced this pull request May 13, 2019
Add UseTakeFocus, Fixes PhoenicisOrg#936, required for PhoenicisOrg#937
008e65f
@Kreyren Kreyren mentioned this pull request May 13, 2019
Merged
ImperatorS79 pushed a commit that referenced this pull request May 15, 2019
@ImperatorS79
Add UseTakeFocus, Fixes #936, required for #937 (#939)
9494609
@Kreyren Kreyren force-pushed the MTG branch 2 times, most recently from d008843 to c1cc2f8 Compare May 16, 2019 11:23
@Kreyren
Copy link
Contributor Author

Kreyren commented May 16, 2019

Game has been marked as testing, requesting merge if game doesn't work blame me and i will fix it; else push into release.

Kreyren
Kreyren commented May 16, 2019
View reviewed changes
Copy link
Contributor Author

@Kreyren Kreyren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubt that wine.DXVK() is recognized assuming that all scripts are using wine.dxvk()

Blame @ImperatorS79 !

@ImperatorS79
Copy link
Contributor

ImperatorS79 commented May 16, 2019 •
edited
Loading

So it has changed ? Ok then ^^.

EDIT: @Kreyren it is DXVK, I have just verified it.

@Kreyren
Copy link
Contributor Author

Kreyren commented May 18, 2019

So it has changed ? Ok then ^^.

EDIT: @Kreyren it is DXVK, I have just verified it.

My bad then i'm the only one using wine.dxvk() it seems.. meh feels wierd to not use snakename, but i change it everywhere too 🤔

Kreyren
Kreyren commented May 19, 2019
View reviewed changes
Copy link
Contributor Author

@Kreyren Kreyren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wizard?

@ImperatorS79
Copy link
Contributor

Thé installation wizard.

@ImperatorS79 ImperatorS79 merged commit 54805e5 into PhoenicisOrg:master May 19, 2019
@Kreyren
Copy link
Contributor Author

Kreyren commented May 19, 2019

Thé installation wizard.

elaborate there is no docummentation on it

@Kreyren
Copy link
Contributor Author

Kreyren commented May 19, 2019 •
edited
Loading

@ImperatorS79 Also did you test that it's working?

@ImperatorS79
Copy link
Contributor

No, I thought you did it. But it is in testing so not a big problem. I should be more careful about this.

@Kreyren
Copy link
Contributor Author

Kreyren commented May 19, 2019 •
edited
Loading

@ImperatorS79 Configuration is tested manually not in phoenicis.. so it should work no issue.

I should be more careful about this.

No just approve all testing! It would make development easier o.o (no sarcasm)

@Kreyren
Copy link
Contributor Author

Kreyren commented May 19, 2019 •
edited
Loading

Results in:
image

What exactly did you change on UseTakeFocus?

EDIT: Trying to fix

  • Err on line 1, fixed
  • Changed UseTakeFocus on line 3 on snakename.

image

This seems like other issue.

Script should be fixed now, @ImperatorS79 repush plz.

@Kreyren
Copy link
Contributor Author

Kreyren commented May 20, 2019

Relevant: #881

@Kreyren Kreyren mentioned this pull request Jun 4, 2019
Merged
petermetz pushed a commit to petermetz/scripts that referenced this pull request Jun 7, 2020
@petermetz
Add UseTakeFocus, Fixes PhoenicisOrg#936, required for PhoenicisOrg#937…
5284df5 
… (PhoenicisOrg#939)
petermetz pushed a commit to petermetz/scripts that referenced this pull request Jun 7, 2020
@petermetz
Add Magic The Gathering Arena (PhoenicisOrg#937)
94a9ebf 

* Update application.json

* Update script.json

* Update script.js

* Update script.js

* Update script.js

* Update script.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zemogiter Zemogiter Zemogiter left review comments

@ImperatorS79 ImperatorS79 ImperatorS79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: Magic: The Gathering Arena
3 participants
@Kreyren @ImperatorS79 @Zemogiter