Addon "Better Check" created #2049
Conversation
Square removed one byte from end of character name (max character name length is 15 anyway so, not sure why it was ever 16, but there you go)
Incoming Chat fix
Adding NyzulHelper addon.
Updated for new battle message when the boss uses Imperfect Defense shell, this will require an update of resources before pushing to live.
Report file load error instead of erroneously saying "can't find the file". Also brought default "binds" file into the loop
Let's report errors
[battlmod] Update new ambu message
Updated to use the packets lib and cleared some gearswap code that was left on the addon.
[translate] Update to use the packets lib
fix for inventories that contains a space on their names.
Made this change so list command shows TVR songs.
Update setbgm.lua
Update recipes.lua
[fields.lua] Wardrobes and Safe2 fixes
Added mini mode. Added collectables toggle.
Fixed a critical bug that could end with a windower crash, added condensation for targets with the same name, several minor fixes.
New song October update
Update setbgm.lua
[battlemod] Critical fix and new feature added
…results [battlemod] add crafting display toggle
Back to hardcoded packet modification instead of library, bug fix when several incoming text with mode 204 comes in a short period of time.
[translate] back to hardcoded packet, bug fix
Song name was confirmed from obtaining and using the key item "Sheet of harvest tunes" during the halloween 2020 event.
Update setbgm.lua
Arcon likes cows. Do cows like acorns?
Make organizer also work with Nomad Moogles
Check for bag availableness in MyHome and Dimmer.
Added new items to slips lib
Update slips.lua
Increased delay
Extend soul_plates table
changed mob lvl to 0x7FFFFFFF for better readability and memory as suggested by randomnick112233
There was a problem hiding this comment.
In addition to the comments within the code, the style of the code is a bit over the place and does not match our common style very well. Especially the indentation is off in some places, try to use 4 space indentations for every level of nesting. You have some parentheses that are unnecessary, some unnecessary spaces before function calls, and missing spaces after commas.
Aside from the indentation we don't require any of the other stylistic changes, but we'd still appreciate it to make our code base be uniform and easier to read.
|
|
||
| -- sets local tables | ||
| local valid_message_ids = S{170,171,172,173,174,175,176,177,178} | ||
| local mchal = {'Very Weak':color(259),'Inredibly Easy Prey':color(259),'Easy Prey':color(259),'A Decent Challenge':color(2),'Evenly Matched':color(53),'Tough':color(159),'Very Tough':color(124),'Incredibly Tough':color(167)} |
There was a problem hiding this comment.
I would split this table (and mstat as well) into multiple lines, just so the colors are more easily adjustable. This could also be made configurable via settings, so every user can define their own colors, but it's fine for the first version.
|
|
||
| -- gets mob level | ||
| if lvl > 0x7FFFFFFF then | ||
| lvl = -1 |
There was a problem hiding this comment.
I think using something like '?' would be better than -1, I feel that would just be confusing for non-technical people who don't know that -1 is sometimes used as a dummy value.
There was a problem hiding this comment.
-1 is in line with the behavior of battlemod. The value is used to describe the mobs one would fight at level 1.
There was a problem hiding this comment.
Still feels wrong unless -1 is the actual value reported. Speaking of which, what is the actual value?
There was a problem hiding this comment.
2147483649 (0x80000001)
There was a problem hiding this comment.
oh sorry nvm its reporting 4294967295 (0xFFFFFFFF) which is twos compliment for -1
There was a problem hiding this comment.
okay so Sephodious, we talked it over and if you require('bit') with the rest of your requires... and then instead of doing...
local lvl = mobinfo['Param 1']
-- gets mob level
if lvl > 0x7FFFFFFF then
lvl = -1
end
Just do
local lvl = bit.tobit(mobinfo['Param 1']) -- convert unsigned int to signed int
| else if (message_id == 249) then | ||
| local target = windower.ffxi.get_mob_by_id(mobinfo['Target']) or {name=('Unknown')} | ||
|
|
||
| windower.add_to_chat(2, "[%s] Their power is over 9000!! (Impossible to gauge)":format(target.name:color(167))) |
There was a problem hiding this comment.
I'm not sure if many people would appreciate that line 😅 Probably better to just use a neutral text, like Impossible to gauge.
There was a problem hiding this comment.
I lol'd . IDK how I feel about this one. Arcon makes a point but these add-ons are made by the community and a little personal flavor text never hurt anyone. Its not like we're some real project.
| -- uses incoming chunk so that we can block standard /check text | ||
| windower.register_event('incoming chunk',function (id,original,modified,injected,blocked) | ||
|
|
||
| -- ignores packets that don't begin with 29 |
There was a problem hiding this comment.
Technically it ignores packets that don't have ID 0x029 :)
|
|
||
| -- sets local tables | ||
| local valid_message_ids = S{170,171,172,173,174,175,176,177,178} | ||
| local mchal = {'Very Weak':color(259),'Inredibly Easy Prey':color(259),'Easy Prey':color(259),'A Decent Challenge':color(2),'Evenly Matched':color(53),'Tough':color(159),'Very Tough':color(124),'Incredibly Tough':color(167)} |
There was a problem hiding this comment.
Typo on IEP - Inredibly should be Incredibly.
Is there a reason for changing "Too Weak to be Worthwhile" to "Very Weak"? I understand that some of the other slight changes are probably to allow for a more natural flowing sentence, but Too Weak... fits fine as it is.
There was a problem hiding this comment.
Needs to match in-game terms imo.
| local chal = mchal[mobinfo['Param 2'] - 63] | ||
| local stat = mstat[message_id - 170] | ||
|
|
||
| windower.add_to_chat(5, "The [%s] is (Lvl.%s), has ~%s~ and seems like its {%s}":format(target.name:color(2), tostring(lvl):color(213), stat:color(1), chal)) |
There was a problem hiding this comment.
"seems like its" -> "seems like it's"
|
Hey, sorry i haven't been around. I'll get started on all this later today or tomorrow and resubmit. Thanks for the suggestions and comments! |
Created an Addon called Better Check (bcheck) that livens up the check a bit. I know some other mods did this already but i didn't want all the extra that came with it. Just wanted to change the /check and nothing else.