Adding NyzulHelper addon. #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit of NyzulHelper addon.
z16
requested changes
Sep 6, 2020
There was a problem hiding this comment.
For the most part the addon looks fine, function-wise. Stylistically, since we try to go for a uniform style please use 4 spaces for one level of indentation, use single quotes for strings and add a new line at the end of the file, and prefer multi-line if over single-line.
Also, for the addon to be listed in the launcher you need to add an entry into the addons.xml file. You can copy the structure for other addons in there.
I wish I could provide some insight into the functional aspect as well, but I know too little about Nyzul to contribute, so I'll trust your judgment here.
Fixed incorrect text in disclaimer. Made indentation uniform. Switched all string literals to use single qoutes. Made suggested help command change.
|
Thank you so much for taking the time to review my code. I have made all of the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of NyzulHelper addon.