Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

DEX-1246: pipeline_status for AssetGroup #744

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Jul 6, 2022

Pull Request Overview

  • Add pipeline_status() (and GET API reference to it) to AssetGroup objects
  • Only include preparation section, per ticket discussion

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #744 (c1ca6ad) into main (856f459) will decrease coverage by 0.4%.
The diff coverage is 63.6%.

❗ Current head c1ca6ad differs from pull request most recent head 6dbaeae. Consider uploading reports for the commit 6dbaeae to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #744     +/-   ##
=======================================
- Coverage   74.6%   74.1%   -0.5%     
=======================================
  Files        227     227             
  Lines      21274   21448    +174     
  Branches    4047    4082     +35     
=======================================
+ Hits       15880   15913     +33     
- Misses      4239    4379    +140     
- Partials    1155    1156      +1     
Impacted Files Coverage Δ
app/modules/asset_groups/models.py 76.1% <61.9%> (+0.3%) ⬆️
app/modules/asset_groups/schemas.py 99.1% <100.0%> (+<0.1%) ⬆️
app/modules/sightings/resources.py 55.1% <0.0%> (-24.7%) ⬇️
app/extensions/elasticsearch/__init__.py 79.5% <0.0%> (+0.1%) ⬆️
app/extensions/git_store/__init__.py 75.9% <0.0%> (+0.2%) ⬆️
app/modules/individuals/models.py 84.1% <0.0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23fd68...6dbaeae. Read the comment docs.

@naknomum naknomum force-pushed the dex1246_pipeline_status_on_asset_group_api branch from 8878e2d to c1ca6ad Compare July 6, 2022 18:30
@naknomum naknomum marked this pull request as ready for review July 6, 2022 18:58
@naknomum naknomum requested a review from bluemellophone July 6, 2022 18:59
Copy link
Contributor

@bluemellophone bluemellophone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluemellophone bluemellophone force-pushed the dex1246_pipeline_status_on_asset_group_api branch from c1ca6ad to 6dbaeae Compare July 6, 2022 19:26
@bluemellophone bluemellophone merged commit 006c4a5 into main Jul 6, 2022
@bluemellophone bluemellophone deleted the dex1246_pipeline_status_on_asset_group_api branch July 6, 2022 19:26
@bluemellophone bluemellophone added this to the Release 1.0.1 milestone Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants