This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
dex 1117 - Replace progress with pipeline_status in Asset Group #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atticus29
approved these changes
Jul 8, 2022
| resultData?.data?.progress_preparation || {}; | ||
| const pipelineStatus = get( | ||
| resultData, | ||
| 'data.pipeline_status.preparation', |
There was a problem hiding this comment.
I love that we all prefer using get() in a slightly different way lol.
brmscheiner
approved these changes
Jul 12, 2022
src/pages/assetGroup/AssetGroup.jsx
Outdated
| </> | ||
| )} | ||
| {!isPreparationFailed && | ||
| !isProgressSettled(pipelineStatusPreparation) && ( |
There was a problem hiding this comment.
i don't love these nested &&s. possible to set a variable to isPreparationFailed && !isProgressSettled(pipelineStatusPreparation) above?
There was a problem hiding this comment.
Yes. I restored the showPreparationInProgressAlert variable in ec3b7a0
src/pages/assetGroup/AssetGroup.jsx
Outdated
| <> | ||
| <LinearProgress | ||
| style={{ | ||
| borderTopLeftRadius: '4px', |
There was a problem hiding this comment.
could be 4 instead of '4px'
There was a problem hiding this comment.
(there are a couple more of these further down in the file too)
There was a problem hiding this comment.
Changed in ec3b7a0
Emily-Ke
deleted the
dex-1117-asset-group-remove-dependence-on-progress-object
branch
Emily-Ke
added a commit
that referenced
this pull request
Jul 29, 2022
* Automatic Docker builds on tagged releases and PRs with multi-platform support * Remove nightly action, which was merged into build * Allow all files to be copied in * Dex 761 social group site settings (#419) * DEX-761 flesh out social group form except for multipleInGroup * DEX-761 begin fleshing out the switch * DEX-761 continue with fleshing out the switch * DEX-761 add useEffect * DEX-761 rename the role component, clean up, and remove the unnecessary useState * DEX-761 internationalize and add description as caption * DEX-761 respond to code review feedback * DEX-761 remove unecessary flexbox div * DEX-761 handle the case where a guidless role makes it into the SocialGroupRole component * move server status components to siteStatus directory * Change server status text to site status * Add server status SuperText keys, prevent 'hide' prop from passing to Text * Internationalize aria labels in site status components * dex 1117 - Replace progress with pipeline_status in Asset Group (#420) * Replace asset group progress with pipeline_status * Change px to number and abstract showAlert in AssetGroup * Add public AGS page (#416) * Add public AGS page * Remove unused property * Fixes * Rename things * Remove unused translation key * use new terms (#418) * begin release procedure (#424) * begin release procedure * clarify about merge conflicts * respond to feedback * respond to code review feedback * Update release procedure doc * Run on sentence Co-authored-by: Ben Scheiner <[email protected]> * DEX-922 implement stickyHeader and add a meaningful maxHeight to ever… (#430) * DEX-922 implement stickyHeader and add a meaningful maxHeight to every DataDisplay. Also add horizontalScroll * DEX-922 remove seemingly unnecessary horizontal scroll prop * DEX-922 respond to code review feedback. Remove default maxHeight for Card component and replaced with optional styles, which was then implemented for ImageCard and StatusCard. Remove maxHeight from Card in relationshipCard, remove unused paperStyles from DataDisplay. * DEX-922 respond to code review feedback pt 2 * DEX-922 add tableContainerStyles to DataDisplay and remove maxHeight * DEX-922 remove tableContainerStyles from SightingsDisplay and fix a few little things * DEX-922 final little fixes * Compute new form state from previous state in Settings (#433) * 922 follow up (#435) * DEX-922 print the collaboration data to make the stackBlitz question easier * DEX-922 I do not understand why tableData was undefined, but cool, codex, I can play this game with you * DEX-922 try disablePortal * DEX-922 change the z-index * DEX-922 clean up * DEX-922 respond to code review feedback * Update version to 1.0.2 (#436) Co-authored-by: Jason Parham <[email protected]> Co-authored-by: Mark <[email protected]> Co-authored-by: Ben Scheiner <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
developbranch, notmainAll text is internationalizedNo user facing textPull Request Overview
pipeline_statusproperty instead of itsprogress_preparationproperty.This is the expected behavior: