Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

dex 1462 - Fix edit custom field form's required toggle #461

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Emily-Ke
Copy link
Contributor

Pull request checklist:

  • Features and bugfixes should be PRed into the develop branch, not main
  • All text is internationalized No new text
  • There are no linter errors
  • New features support all states (loading, error, etc) No new features

Which JIRA ticket(s) and/or GitHub issues does this PR address?

  • DEX-1462: custom fields required being weird

Pull Request Overview

  • The Required Switch at /settings/fields/save-custom-field/:type?/:id? was not correctly reflecting the required state of the field as defined in the field's schema. Changing the prop from value to checked fixed it.

configuration

@Emily-Ke Emily-Ke requested a review from Atticus29 September 28, 2022 21:35
Copy link
Contributor

@Atticus29 Atticus29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Emily-Ke Emily-Ke merged commit f93ff9d into develop Sep 28, 2022
@Emily-Ke Emily-Ke deleted the dex-1462-fix-edit-custom-field-required-field branch September 28, 2022 21:57
@Atticus29 Atticus29 mentioned this pull request Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants