This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
PRs for v1.1.0 release #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DEX-761 flesh out social group form except for multipleInGroup * DEX-761 begin fleshing out the switch * DEX-761 continue with fleshing out the switch * DEX-761 add useEffect * DEX-761 rename the role component, clean up, and remove the unnecessary useState * DEX-761 internationalize and add description as caption * DEX-761 respond to code review feedback * DEX-761 remove unecessary flexbox div * DEX-761 handle the case where a guidless role makes it into the SocialGroupRole component
…to-site-status dex 1197 - rename server status to site status
* Replace asset group progress with pipeline_status * Change px to number and abstract showAlert in AssetGroup
Automatic Docker builds on tagged releases and PRs
* Add public AGS page * Remove unused property * Fixes * Rename things * Remove unused translation key
* begin release procedure * clarify about merge conflicts * respond to feedback * respond to code review feedback * Update release procedure doc * Run on sentence Co-authored-by: Ben Scheiner <[email protected]>
#430) * DEX-922 implement stickyHeader and add a meaningful maxHeight to every DataDisplay. Also add horizontalScroll * DEX-922 remove seemingly unnecessary horizontal scroll prop * DEX-922 respond to code review feedback. Remove default maxHeight for Card component and replaced with optional styles, which was then implemented for ImageCard and StatusCard. Remove maxHeight from Card in relationshipCard, remove unused paperStyles from DataDisplay. * DEX-922 respond to code review feedback pt 2 * DEX-922 add tableContainerStyles to DataDisplay and remove maxHeight * DEX-922 remove tableContainerStyles from SightingsDisplay and fix a few little things * DEX-922 final little fixes
* DEX-922 print the collaboration data to make the stackBlitz question easier * DEX-922 I do not understand why tableData was undefined, but cool, codex, I can play this game with you * DEX-922 try disablePortal * DEX-922 change the z-index * DEX-922 clean up * DEX-922 respond to code review feedback
* Add queue card * Add time remaining card * Update .eslint rules to allow FormattedNumber style prop * Add progress card * Add PipelineStepProgressGrid to automated StatusCard steps * Update StatusCard in progress messages to include start time * Add start date card * Add progress cards to AssetGroup * Add CircularProgressAsIcon for automated StatusCard steps * Change TimelineStep ProgressIcon to empty hourglass for all stages * Move all progress statistics into ProgressMetrics * Round ProgressMetrics progress to hundredth * Move StatusCard date with time formatting to helper function * Separate pipeline steps from StatusCard * Move getDateString, getDateTimeString, and getStage to statusCardUtils * Internationalize StatusCard getDateString * Clean up status card related entries in en.json
* DEX-1176 add minWidth * DEX-1176 respond to code review feedback * DEX-1176 removal accidental second flex display
* Remove data manager
* Introduce script to print unused keys * Fix script
* Send request to create social group * Get add and delete social groups working * Edit social group page with name editing * Control panel shuffle * Social group form * Remove individual from social group functionality * Table of members on social group page * Add roles to social group card * Remaining functionality * Loading and error states for AddMembersDialog * Loading and error states for RemoveFromSocialGroupDialog * Loading and error states in AddSocialGroupDialog * Loading and error states for AddToSocialGroupDialog * Improve looks of social group roles setup dialog * Rename mixed things to Preferences * Forward ref to overflow controller * Address remaining comments * Address final comments * Fix an eslint error * Address PR comments * Address QA comments
* Restore individual gallery link, add route and page component * Add basic individual gallery page states, without gallery * Add asset gallery * Handle clamped gallery images, display info alert * Add asset metadata * Justify gallery left instead of center * Handle image load error * Add alt text to gallery images and description to image error * Move const outside of component, memoize transformToAssets, replace transform with reduce
* Clear success and errors on submission and alert dismissal * Give success and error alert the same styles, use description instead of children * Update getOptionSelected logic
* Fix annotation alert copy to be >= instead of >
…d) (#446) * Remove unused relationships code * Delete additional files
* Proposed table action group refactor * Support more functionality * PR feedback
* Move LatLongEditor state to reducer * Fix EditSightingMetadata dependency * Memoize metadata passed to EditSightingMetadata * Define LatLongEditor action and setter types
* Return single component instead of array from UserManagersCollaborationEditTable * Add formatUserMessage util, remove user customBodyRenders * Change table title from 'Edit Collaborations' to 'Collaborations' * Remove 'restore' action * Change revoke collaboration icon from trash can to minus sign * Move Actions column to customBodyComponent * Replace revokeCollab options with multi-option API options * Simplify COLLAB_REVOKE_ERROR_SUPPLEMENTAL internationalization * Update columns * Add edit collaboration dialog * Update processRevoke to new collaboration API * Cleanup * rename labels to labelIds, * move object definition outside of component * add optional chaining operator * Move collaboration model.js to collaborationUtils.js * Change from switch to if for getPatchCollaborationOperations * Cleanup: remove comment, simplify style declaration * Move FormattedReporter to components and apply to bulk import and sighting headers * Apply formatUserMessage to collaboration management form * Add formatUserMessage to formatters and apply to UserProfile and EditCollaborationDialog * Move CollaborationManagementForm into userManagement components directory
* 1379 site setting FE changed still doesn't work * looking closer to real thing removed another unused file correcetd a few more issues * Tempfix infinite loopz * Migrate to use timestamp instead of deprecated version property * Use correct query key, stop sending custom fields on certain forms * Migrate assets * Migrate delete asset functionality * Swap to new api in useRemoveCustomField * Include files in site setting update requests * Remove usePutSiteSettings * Switch to data, simplify SettingsTextInput in site settings forms * Remove LocationIdViewer from EncounterCard * Use site settings data instead of result or dataUpdatedAt * Remove unused useMemo dependency from useUserMetadataSchemas * Rename useSiteSettings, remove redundant dataAccessor Co-authored-by: Howard Windsor <[email protected]> Co-authored-by: Em <[email protected]> Co-authored-by: Emily-Ke <[email protected]>
…456) * Add asterisks to SpecifiedTimeEditor fields * Update report sighting validation of specifiedTime fields * Move time validations to variables for readability
…to better guide end user to enter URLs correctly. Form validation improvements forthcoming in subsequent ticket (#458)
* Fix custom field form required input
#440) * add a second empty encounter if the AGS submission has more than one animal * DEX-759 flesh out second encounter with same data as first * DEX-759 respond to code review feedback
* DEX-1328 enable user manager to see other users collab tables and change copy to accommodate different users viewing the content * DEX-1328 make progress on manager-specific approve and revoke calls * DEX-1328 DRY up the managerPatch * DEX-1328 move the await to await an actual api call lol * DEX-1328 implement the UserManagersCollaborationEditTable for user managers * DEX-1328 add little fixes after self code review * DEX-1328 respond to code review feedback and put the UserManagerCollaborationEditTable in a Paper wrapper * DEX-460 respond to code review feedback
* DEX-1452 change copy and user settings schemas to reflect BE change to individual_merge_all * DEX-1452 clean up * DEX-1452 respond to code review feedback
* DEX-1435 add print statements to compare model choices and uniqAlgorithms * DEX-1435 create the new notification dialogs and establish the new schemas for the new notifications * DEX-1435 continue implementing BE changes, this time from PR 822 on the BE * DEX-1435 clean up and internationalize * DEX-1435 add last improvements during pre code review * DEX-1435 fix i8n issue * DEX-1435 change your to a * DEX-1435 respond to code review feedback
* Update user collaboration cards * Update MyCollaborationsCard columns to fix no-unstable-nested-components error * Add AddCollaboratorButton shell * Add logic to AddCollaboratorButton * Internationalize default error message for handleAxiosError * Remove 'limit' and 'offset' from useGetUsers * Fix useMutation error handling * Rename prefixApiURL to prefixApiUrl * Rename useHandleAxiosError to useHandleRequestError and update logic * Inline handleSubmitCollaborator * Rename axiosUtils.js to requestUtils and prefixApiUrl to withApiPrefix
Atticus29
commented
Oct 6, 2022
Atticus29
commented
Oct 6, 2022
| const matches = Object.values(results); | ||
| const trueMatches = matches.filter(match => { | ||
| const matchingLines = match?.line || []; | ||
| const linesWithSingleQuoteMatch = getLinesWithMatch( |
There was a problem hiding this comment.
These seem to be mislabeled?
Atticus29
commented
Oct 6, 2022
| const CoreComponent = <CoreForwardRef value={label} {...rest} />; | ||
|
|
||
| return noWrap ? ( | ||
| <OverflowController title={label}> |
There was a problem hiding this comment.
I still want to ask you about this, @Emily-Ke
Atticus29
commented
Oct 6, 2022
| @@ -0,0 +1,32 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
I don't understand what this file is or does by its name.
Atticus29
commented
Oct 6, 2022
| } | ||
| }, [get(savedMapLatLng, '0'), get(savedMapLatLng, '1')]); | ||
| }, [latitudeString, longitudeString, setterType]); // onChange is intentionally excluded. |
There was a problem hiding this comment.
Leaving these notes on useEffects will be super handy, I think.
Atticus29
commented
Oct 6, 2022
| () => ({ data, loading, error, siteSettingsVersion }), | ||
| [data, loading, error, siteSettingsVersion], | ||
| ); | ||
| return useFetch({ |
There was a problem hiding this comment.
I don't understand why this file change was necessary.
Atticus29
commented
Oct 6, 2022
| master: [4096, 4096], | ||
| }; | ||
|
|
||
| function isAssetImageClamped({ imageWidth, imageHeight }) { |
Atticus29
commented
Oct 6, 2022
|
|
||
| if ( | ||
| !formTimeSpecificity || | ||
| isTimeSpecificityDefault || |
There was a problem hiding this comment.
Why would default result in incomplete time specificity here?
Emily-Ke
approved these changes
Oct 6, 2022
Atticus29
commented
Oct 6, 2022
| @@ -0,0 +1,28 @@ | |||
| export function formatUserMessage(user, intl) { | |||
There was a problem hiding this comment.
I think this file should have a more illustrative name than utils.js. I don't love relying on directory structure for context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding all PRs in since the previous release PR #437 .
Includes:
93c9bf0 dex 1341 - add collaboration from user page (#464) 464 1341
ad726ae Dex 1435 new notifications to fe (#463) 463 1435
d558ff2 Dex 1452 user preferences all merge (#462) 462 1452 and 1451
73b3197 Dex 1328 user manager view collabs (#460) 460 1328
fd9d326 add a second empty encounter if the AGS submission has more than one … (#440) 440 759
343ad79 DEX-1443 cherry pick e8c4a2d from DEX-1443-empty-dropdown-as-array be… (#459) 459 1443
f93ff9d dex 1462 - Fix edit custom field form's required toggle (#461) 461 1462
a29d497 DEX-1445 add info alert on splash setting and general settings pages to better guide end user to enter URLs correctly. Form validation improvements forthcoming in subesequent ticket (#458) 458 1445
4aa18da dex 1417 - require both sighting time fields when reporting sighting (#456) 456 1417
b3a46e8 DEX-1433 remove EDM build date and commit hash from Site Status page (#455) 455 1433
764fcfd Integrate new site settings API (#449) 449 1379
c45eec8 dex-1329 - show collaboration type in table (#451) 451 1329
d37b7ed dex-1401 - incorrect sighting metadata payload (#453) 453 1401
a0539ff Fix page error when no notification message (#452) 452 N/A
a5b1220 Remove unused file PipelineStepProgressGrid (#450) 450 N/A
c845095 Proposed table action group refactor (#448) 448 N/A
092f469 Remove unused relationships code (including relationships custom field) (#446) 446 N/A
82c96d8 dex-1017 - individual photo gallery - fix copy (#447) 447 1017
a5b1412 dex-1343 - clear collaboration failure after success (#445) 445 1343
0104ac0 dex-1017 - individual photo gallery (#444) 444 1017
8e88638 Social groups UI (#438) 438 762, 1349
127cbdb Script for printing unused translation keys (#443) 443 N/A
2b14d53 dex 1371 - remove data manager role (#442) 442 1371
ab9a473 DEX-1176 add minWidth (#434) 434 1176
155b696 dex 1082 - sighting queue and progress metrics (#432) 432 1082
a267668 Update version to 1.0.2 (#436) 436 N/A
06dda19 922 follow up (#435) 435 DEX-922