Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

DEX-1445 add info alert on splash setting and general settings pages … #458

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Atticus29
Copy link
Contributor

…to better guide end user to enter URLs correctly. Form validation improvements forthcoming in subsequent ticket

Description

DEX-1445 was originally reported as an error in processing the URL of social media links.
Upon further investigation, the issue was that the user must provide the full URL, including the "https://" portion.

This is a form validation issue, and further inspection led to the discovery of several other form validation issues on the general settings page as well as the splash settings page.

It was decided that adding such form validation in the current effort was scope creep, so we are just putting a little bit of copy at the top of the page to suggest that the user type "https://".

I decided that the text alone didn't look urgent enough, so I put it in an alert.

Screen Shot 2022-09-26 at 4 08 39 PM

Pull request checklist:

  • Features and bugfixes should be PRed into the develop branch, not main
  • All text is internationalized
  • There are no linter errors
  • New features support all states (loading, error, etc)
    • NA

Which JIRA ticket(s) and/or GitHub issues does this PR address?

DEX-1445

Thanks for keeping it clean! Feel free to merge your own pull request after it has been approved - just use the "squash & merge" option.

…to better guide end user to enter URLs correctly. Form validation improvements forthcoming in subsequent ticket
Copy link
Contributor

@Emily-Ke Emily-Ke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Atticus29 Atticus29 merged commit a29d497 into develop Sep 28, 2022
@Atticus29 Atticus29 deleted the DEX-1445-hero-url branch September 28, 2022 19:54
@Atticus29 Atticus29 mentioned this pull request Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants