This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
DEX-1445 add info alert on splash setting and general settings pages … #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to better guide end user to enter URLs correctly. Form validation improvements forthcoming in subsequent ticket
Description
DEX-1445 was originally reported as an error in processing the URL of social media links.
Upon further investigation, the issue was that the user must provide the full URL, including the "https://" portion.
This is a form validation issue, and further inspection led to the discovery of several other form validation issues on the general settings page as well as the splash settings page.
It was decided that adding such form validation in the current effort was scope creep, so we are just putting a little bit of copy at the top of the page to suggest that the user type "https://".
I decided that the text alone didn't look urgent enough, so I put it in an alert.
Pull request checklist:
develop
branch, notmain
Which JIRA ticket(s) and/or GitHub issues does this PR address?
DEX-1445
Thanks for keeping it clean! Feel free to merge your own pull request after it has been approved - just use the "squash & merge" option.