This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Fix page error when no notification message #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emily-Ke
commented
Aug 26, 2022
| </Text> | ||
| ); | ||
| const notificationText = | ||
| currentNotificationSchema?.notificationMessage ? ( |
There was a problem hiding this comment.
Almost all of this diff is formatting caused by adding this line. Everything was indented because of this.
Emily-Ke
commented
Aug 26, 2022
| > | ||
| {intl.formatMessage( | ||
| { | ||
| id: currentNotificationSchema.notificationMessage, |
There was a problem hiding this comment.
This is the one other change. I removed the optional chaining operator because the new condition above that determines if this code should be run is that currentNotificationSchema.notificationMessage exists.
brmscheiner
approved these changes
Aug 26, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
developbranch, notmainNew features support all states (loading, error, etc)No new featuresWhich JIRA ticket(s) and/or GitHub issues does this PR address?
Pull Request Overview
nullinstead of formatted text if there is no notification message. This prevents react-intl from throwing an uncaught error whenundefinedis passed toid