Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Social groups UI #438

Merged
merged 23 commits into from
Aug 12, 2022
Merged

Social groups UI #438

merged 23 commits into from
Aug 12, 2022

Conversation

brmscheiner
Copy link
Contributor

Pull request checklist:

  • Features and bugfixes should be PRed into the develop branch, not main
  • All text is internationalized
  • There are no linter errors
  • New features support all states (loading, error, etc)

Which JIRA ticket(s) and/or GitHub issues does this PR address? DEX-762, DEX-1349

Thanks for keeping it clean! Feel free to merge your own pull request after it has been approved - just use the "squash & merge" option.

@brmscheiner brmscheiner requested a review from Emily-Ke July 29, 2022 21:07
Copy link
Contributor

@Emily-Ke Emily-Ke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Settings.jsx needs the SettingsBreadcrumbs added to it.
  • A few of the files have lint warnings or errors.

locale/en.json Outdated Show resolved Hide resolved
src/pages/splashSettings/SplashSettings.jsx Show resolved Hide resolved
src/constants/queryKeys.js Outdated Show resolved Hide resolved
src/constants/queryKeys.js Outdated Show resolved Hide resolved
src/models/individual/useQueryIndividualsByGuid.js Outdated Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Outdated Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Show resolved Hide resolved
src/pages/socialGroups/SocialGroups.jsx Outdated Show resolved Hide resolved
src/components/dialogs/RemoveFromSocialGroupDialog.jsx Outdated Show resolved Hide resolved
src/pages/socialGroups/SocialGroups.jsx Show resolved Hide resolved
src/pages/individual/components/SocialGroupsDisplay.jsx Outdated Show resolved Hide resolved
src/components/cards/SocialGroupsCard.jsx Outdated Show resolved Hide resolved
src/components/cards/SocialGroupsCard.jsx Outdated Show resolved Hide resolved
src/components/cards/SocialGroupsCard.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Atticus29 Atticus29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments of varying levels of importance.

src/AuthenticatedSwitch.jsx Outdated Show resolved Hide resolved
src/components/cards/SocialGroupsCard.jsx Show resolved Hide resolved
src/components/cards/SocialGroupsCard.jsx Outdated Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Show resolved Hide resolved
src/pages/socialGroups/SocialGroup.jsx Show resolved Hide resolved
src/pages/socialGroups/SocialGroups.jsx Outdated Show resolved Hide resolved
src/pages/socialGroups/SocialGroups.jsx Outdated Show resolved Hide resolved
docs/contribution-guide.md Outdated Show resolved Hide resolved
src/pages/socialGroups/SocialGroups.jsx Outdated Show resolved Hide resolved
locale/en.json Outdated Show resolved Hide resolved
src/components/dialogs/AddToSocialGroupDialog.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Emily-Ke Emily-Ke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brmscheiner brmscheiner merged commit 8e88638 into develop Aug 12, 2022
@brmscheiner brmscheiner deleted the social-groups-ui branch August 12, 2022 22:31
@Atticus29 Atticus29 mentioned this pull request Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants