Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of "in" in IDL #13

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Remove use of "in" in IDL #13

merged 2 commits into from
Jun 13, 2018

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jun 13, 2018 •
edited
Loading

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=30011.

Drive-by fix: [SameObject] and whitespace.

@foolip
Remove use of "in" in IDL
2493eef 
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=30011.

Drive-by fix: [SameObject] and whitespace.
@foolip foolip requested a review from andrenatal June 13, 2018 10:34
@foolip
Copy link
Collaborator Author

foolip commented Jun 13, 2018

@saschanaz, care to review this follow-up to your changes?

@foolip foolip changed the title Remove us of "in" in IDL Remove use of "in" in IDL Jun 13, 2018
@saschanaz
Copy link
Contributor

Oh, I was about to open an identical pull request 🤣

Can you also replace SpeechRecognitionList into SpeechRecognitionResultList? Those are just simple typos.

@foolip
Copy link
Collaborator Author

foolip commented Jun 13, 2018

@saschanaz done!

saschanaz
saschanaz approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@foolip foolip merged commit 91c82e6 into master Jun 13, 2018
@foolip foolip deleted the fix-idl-in branch June 13, 2018 11:37
foolip added a commit that referenced this pull request Jun 15, 2018
@foolip
Meta: restore webspeechapi.html to its pre-GitHub state
e0ac7e7 
In the documents itself, the relationship is claimed to be:
webspeechapi.html = speechapi.html + speechapi-errata.html

This was true until until #11 + #13, so revert those changes from
webspeechapi.html, to commit a69322c,
to leave the historical record intact.
@foolip foolip mentioned this pull request Jun 15, 2018
Merged
foolip added a commit that referenced this pull request Jun 15, 2018
@foolip
Meta: restore webspeechapi.html to its pre-GitHub state (#19)
55d64aa 
In the documents itself, the relationship is claimed to be:
webspeechapi.html = speechapi.html + speechapi-errata.html

This was true until until #11 + #13, so revert those changes from
webspeechapi.html, to commit a69322c,
to leave the historical record intact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

@andrenatal andrenatal Awaiting requested review from andrenatal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foolip @saschanaz