Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to the latest Web IDL syntax #11

Merged
merged 8 commits into from
Jun 11, 2018
Merged

Conform to the latest Web IDL syntax #11

merged 8 commits into from
Jun 11, 2018

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Apr 19, 2018 •
edited
Loading

  1. [Exposed] extended attribute is now required Make [Exposed] mandatory, remove [PrimaryGlobal] whatwg/webidl#423
  2. Nested enum is simply a syntax error
  3. implements is replaced by interface mixins (Add mixins whatwg/webidl#433), and then mixins are discouraged if we can write a partial interface.

@foolip
Copy link
Collaborator

foolip commented May 4, 2018

@andrenatal can you review this?

@andrenatal
Copy link

LGTM!

andrenatal
andrenatal approved these changes Jun 5, 2018
View reviewed changes
Copy link

@andrenatal andrenatal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and addresses an issue I was having.

@foolip
Copy link
Collaborator

foolip commented Jun 11, 2018

@saschanaz, how would you like to be credited in https://w3c.github.io/speech-api/webspeechapi.html#acknowledgments?

@saschanaz
Copy link
Contributor Author

how would you like to be credited in https://w3c.github.io/speech-api/webspeechapi.html#acknowledgments?

That would be great! I'll push a commit for that.

@foolip foolip merged commit 03f86e6 into WebAudio:master Jun 11, 2018
@foolip
Copy link
Collaborator

foolip commented Jun 11, 2018

Thanks @saschanaz!

foolip added a commit that referenced this pull request Jun 15, 2018
@foolip
Meta: restore webspeechapi.html to its pre-GitHub state
e0ac7e7 
In the documents itself, the relationship is claimed to be:
webspeechapi.html = speechapi.html + speechapi-errata.html

This was true until until #11 + #13, so revert those changes from
webspeechapi.html, to commit a69322c,
to leave the historical record intact.
@foolip foolip mentioned this pull request Jun 15, 2018
Merged
foolip added a commit that referenced this pull request Jun 15, 2018
@foolip
Meta: restore webspeechapi.html to its pre-GitHub state (#19)
55d64aa 
In the documents itself, the relationship is claimed to be:
webspeechapi.html = speechapi.html + speechapi-errata.html

This was true until until #11 + #13, so revert those changes from
webspeechapi.html, to commit a69322c,
to leave the historical record intact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrenatal andrenatal andrenatal approved these changes

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @foolip @andrenatal