Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial title fix. #59

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Trivial title fix. #59

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9cfe83
Title fix.
Feb 27, 2020
6d933a5
Update Changelog.md
AvdLee Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
### Next Version
- Title fix in `LogsReporter`

AvdLee marked this conversation as resolved.
Show resolved Hide resolved
### 1.5.0
- Change the order of reported sessions ([#54](https://github.com/WeTransfer/Diagnostics/issues/54)) via @AvdLee
- Merge release 1.4.0 into master ([#53](https://github.com/WeTransfer/Diagnostics/pull/53))

### 1.4.0

- Migrate to Bitrise & Danger-Swift ([#52](https://github.com/WeTransfer/Diagnostics/pull/52)) via @AvdLee
- Add charset utf-8 to html head ([#50](https://github.com/WeTransfer/Diagnostics/pull/50)) via @AvdLee

Expand Down
3 changes: 2 additions & 1 deletion Sources/Reporters/LogsReporter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Foundation
struct LogsReporter: DiagnosticsReporting {

static var title: String = "Logs"

static var diagnostics: String {
guard let data = DiagnosticsLogger.standard.readLog(), let logs = String(data: data, encoding: .utf8) else {
return "Parsing the log failed"
Expand All @@ -22,7 +23,7 @@ struct LogsReporter: DiagnosticsReporting {
}

static func report() -> DiagnosticsChapter {
return DiagnosticsChapter(title: "Logs", diagnostics: diagnostics, formatter: self)
return DiagnosticsChapter(title: title, diagnostics: diagnostics, formatter: self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

}
}

Expand Down