Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial title fix. #59

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Conversation

davidsteppenbeck
Copy link
Contributor

No description provided.

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've added a small addition, as we're automatically generating the changelog there's no need to change it manually 🙂

Changelog.md Outdated Show resolved Hide resolved
@@ -22,7 +23,7 @@ struct LogsReporter: DiagnosticsReporting {
}

static func report() -> DiagnosticsChapter {
return DiagnosticsChapter(title: "Logs", diagnostics: diagnostics, formatter: self)
return DiagnosticsChapter(title: title, diagnostics: diagnostics, formatter: self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ghost
Copy link

ghost commented Feb 27, 2020

Warnings
⚠️ Please provide a summary in the Pull Request description
Messages
📖

View more details on Bitrise

📖 Diagnostics: Executed 18 tests, with 0 failures (0 unexpected) in 0.241 (0.370) seconds

Diagnostics.framework: Coverage: 76.97

File Coverage
LogsReporter.swift 92.86%

Generated by 🚫 Danger Swift against 6d933a5

@AvdLee AvdLee merged commit 17586b3 into WeTransfer:master Feb 28, 2020
@ghost
Copy link

ghost commented Feb 28, 2020

Congratulations! 🎉 This was released as part of Release 1.6.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants