Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reorg error log #12925

Merged
merged 3 commits into from
Apr 24, 2024

Use log info

03118b8
Select commit
Loading
Failed to load commit list.
Merged

Fix reorg error log #12925

Use log info
03118b8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (master) succeeded Apr 24, 2024 in 48s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method SatoshiSynchronizer.cs: ExecuteAsync

Annotations

Check warning on line 140 in WalletWasabi/Services/SatoshiSynchronizer.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

❌ Getting worse: Complex Method 

ExecuteAsync already has high cyclomatic complexity, and now it increases in Lines of Code from 119 to 126. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis