Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reorg error log #12925

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Fix reorg error log #12925

merged 3 commits into from
Apr 24, 2024

Conversation

lontivero
Copy link
Collaborator

At the time of opening this PR several blocks were mined per second and there were many reorgs. We were logging this as errors instead of debug or info.

Also, if there is a problem closing the websocket and exception was not caught (to ignore).

Client log

2024-04-23 22:05:00.531 [9] ERROR       SatoshiSynchronizer.ExecuteAsync (132)  Inconsistent index state detected.
Local chain: 2642442/2642442 (0 left- best known block hash: 00000000010bddcb3516bb780c1a7657f551bea4fb331c32dcff5efaffbfbef5
Received filter: 0000000000006f85d79e128b81441b184b8af322644cefc6c8c5e1a8473bbcdb height: 2642442

Server log

2024-04-24 01:04:56.198 [25] WARNING    IndexBuilderService.Synchronize (199)   Reorg observed on the network.
2024-04-24 01:04:56.198 [25] INFO       IndexBuilderService.ReorgOneAsync (312) REORG invalid block: 00000000010bddcb3516bb780c1a7657f551bea4fb331c32dcff5efaffbfbef5

@lontivero lontivero requested a review from adamPetho April 24, 2024 01:30
turbolay
turbolay previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@turbolay turbolay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WalletWasabi/Services/SatoshiSynchronizer.cs Outdated Show resolved Hide resolved
@lontivero
Use log info
03118b8 
Co-authored-by: Turbolay <[email protected]>
@lontivero lontivero merged commit 449a933 into WalletWasabi:master Apr 24, 2024
5 of 8 checks passed
lontivero added a commit that referenced this pull request Apr 28, 2024
@lontivero
Revert "Fix reorg error log (#12925)"
6acc71c 
This reverts commit 449a933.
@lontivero lontivero mentioned this pull request Apr 28, 2024
Closed
lontivero added a commit to lontivero/WalletWasabi that referenced this pull request Apr 28, 2024
@lontivero
Revert "Fix reorg error log (WalletWasabi#12925)"
3142ab8 
This reverts commit 449a933.
lontivero added a commit that referenced this pull request Apr 29, 2024
@lontivero
Revert satoshi notifications (#12946)
ad6e7f6 
* Revert "Notify `SoftwareVersion` and `LegalDocumentVersion` (#12692)"

This reverts commit f8305d2.

* Revert "Fix reorg error log (#12925)"

This reverts commit 449a933.

* Revert "Satoshi notifications (#12400)"

This reverts commit 79b8cf7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolay turbolay turbolay approved these changes

@adamPetho adamPetho Awaiting requested review from adamPetho

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lontivero @turbolay