-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#62 [FEAT, FIX] Feature/edit group 그룹 api 수정 및 개발 #72
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0cf1546
[FIX] : dml에 스키마 삭제하고 테이블 이름만 남게 하기
hye-on 75051a3
[FIX] : 아바타 못찾았을때 상태코드 수정
hye-on 54de066
[CHORE] : 주석삭제
hye-on 1ec4a36
[FIX] : room detail get api에 invitation code 추가
hye-on 85a442a
[FIX] : erd 수정. invitationCode 길이 수정
hye-on a536d70
#62 [FEAT] : 초대받은 사람이 보는 룸정보 api 개발
hye-on b0968b4
#62 [FIX] : null 체크 Optional 클래스에 위임하게 roomUser 가져오는 코드 수정, 방 참가시 이미 …
hye-on 7091a8b
[FIX] : roomUser 찾을 때 에러 던지게 추가
hye-on File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
src/main/java/com/wakeUpTogetUp/togetUp/api/room/dto/response/RoomInfoRes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
package com.wakeUpTogetUp.togetUp.api.room.dto.response; | ||
|
||
import io.swagger.v3.oas.annotations.media.Schema; | ||
import lombok.*; | ||
|
||
|
||
@Schema(description = "룸정보 조회 요청 api 응답") | ||
@Getter | ||
@Setter | ||
@AllArgsConstructor | ||
@NoArgsConstructor | ||
@Builder | ||
public class RoomInfoRes { | ||
|
||
@Schema(description = "룸 정보") | ||
private RoomData roomData; | ||
|
||
@Schema(description = "알람 정보") | ||
private AlarmData alarmData; | ||
|
||
@Builder | ||
@Data | ||
public static class RoomData { | ||
|
||
@Schema(description = "룸아이디" ,example = "1") | ||
private Integer id; | ||
|
||
@Schema( description = "룸이 가지고 있는 알람의 아이콘",example = "⏰") | ||
private String icon; | ||
|
||
@Schema(description = "room name", example = "설여대 기상방") | ||
private String name; | ||
|
||
@Schema(description = "room 소개",example = "소프트웨어융학학과 기상방입니다.") | ||
private String intro; | ||
|
||
@Schema(description = "room 개설일",example = "2020.02.03") | ||
private String createdAt; | ||
|
||
@Schema(description = "함께하는 인원수",example = "6") | ||
private Integer personnel; | ||
|
||
|
||
|
||
} | ||
|
||
@Builder | ||
@Data | ||
public static class AlarmData { | ||
|
||
@Schema(description = "미션의 한국말",example = "자동차") | ||
private String missionKr; | ||
|
||
@Schema(description = "알람 시간", example = "pm 13:00") | ||
private String alarmTime; | ||
|
||
@Schema(description = "그룹알람 울리는 날",example = "주중") | ||
private String alarmDay; | ||
|
||
|
||
} | ||
|
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--table : invitation_code 길이 10으로 수정 | ||
alter table room | ||
add invitation_code varchar(10) null; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: 혹시 코드 컨벤션 적용하셨을까요? 군데군데 적용이 되지 않은 부분이 보이는 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어떤 코드 컨벤션 말하는 걸까요?
뛰어쓰기 말씀하신건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인텔리제이에서 컨트롤 알트 L을 누르면 자동으로 포맷팅 되는 기능이 있습니다! 그걸 적용하셨는지 궁금합니다!
아니면 Save and action에서 저장할 때마다 코드 포맷팅을 하는 기능도 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
글 정렬은 따로 pr을 올리는 것이 좋을 것같아서 따로 pr을 올렸다가 이 pr이 머지 된후에 다시 올리려고 close 하였습니다.
다시 알려주셔서 감사합니다😃