#62 [FEAT, FIX] Feature/edit group 그룹 api 수정 및 개발 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05AM
approved these changes
Nov 3, 2023
Comment on lines
206
to
207
| RoomUser seletedRoomUser = roomUserRepository.findByRoom_IdAndUser_Id(roomId, selectedUserId) | ||
| .orElseThrow(); |
| @@ -101,7 +102,7 @@ public BaseResponse changeRoomHost(@Parameter(hidden = true) @AuthUser Integer u | |||
|
|
|||
| } | |||
|
|
|||
| @Operation(summary = "그룹 디테일 보기 and 초대 받은 사람에게 보이는 그룹 정보 보기 ",description = "그룹 디테일 보기 (설정 화면) and 초대 받은 사람에게 보이는 앱 내 페이지") | |||
| @Operation(summary = "그룹 디테일 보기 ",description = "그룹 디테일 보기 (설정 화면)") | |||
There was a problem hiding this comment.
P3: 혹시 코드 컨벤션 적용하셨을까요? 군데군데 적용이 되지 않은 부분이 보이는 것 같습니다.
There was a problem hiding this comment.
어떤 코드 컨벤션 말하는 걸까요?
뛰어쓰기 말씀하신건가요?
There was a problem hiding this comment.
인텔리제이에서 컨트롤 알트 L을 누르면 자동으로 포맷팅 되는 기능이 있습니다! 그걸 적용하셨는지 궁금합니다!
아니면 Save and action에서 저장할 때마다 코드 포맷팅을 하는 기능도 있습니다.
There was a problem hiding this comment.
글 정렬은 따로 pr을 올리는 것이 좋을 것같아서 따로 pr을 올렸다가 이 pr이 머지 된후에 다시 올리려고 close 하였습니다.
다시 알려주셔서 감사합니다😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☀️ 작업 사항
☀️ 관련 이슈
#62
☀️ 참고 사항