Add sniff to check for add_..._page() functions + unit tests.
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/issue-11-admin-menu-page-functions
branch
4 times, most recently
from
44c37b2 to
5ba7d46
Compare
grappler
force-pushed
the
feature/theme-review-sniffs
branch
from
b8a5e09 to
5dd4758
Compare
grappler
force-pushed
the
feature/issue-11-admin-menu-page-functions
branch
from
5ba7d46 to
0984dbd
Compare
jrfnl
force-pushed
the
feature/issue-11-admin-menu-page-functions
branch
from
0984dbd to
4a01fbf
Compare
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
[Edit] Changed over to use WordPress_Sniffs_Functions_FunctionRestrictionsSniff as the base class rather than Generic_Sniffs_PHP_ForbiddenFunctionsSniff.
This allows for better error messages, keeping it more in line with what people have come to expect from Theme Check.