Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Sniff] Check for adding admin page other than through add_theme_page() #11

Closed
2 tasks done
jrfnl opened this issue Jul 11, 2016 · 0 comments
Closed
2 tasks done

[New Sniff] Check for adding admin page other than through add_theme_page() #11

jrfnl opened this issue Jul 11, 2016 · 0 comments
Labels
approved / in handbook issue: has PR

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Jul 11, 2016 •
edited
Loading

Rule:

Admin Pages only allowed via add_theme_page().

Ref: https://make.wordpress.org/themes/handbook/review/required/theme-check-plugin/#admin-menu

Theme check file covering this rule:

https://github.com/Otto42/theme-check/blob/master/checks/admin_menu.php

To do:

  • Create unit tests
  • Create new sniff
@jrfnl jrfnl mentioned this issue Jul 11, 2016
Closed
@jrfnl jrfnl mentioned this issue Jul 11, 2016
Merged
jrfnl added a commit that referenced this issue Jul 12, 2016
@jrfnl
Add sniff to check for add_..._page() functions + unit tests.
44c37b2 
Closes #11.
grappler pushed a commit that referenced this issue Jul 14, 2016
@jrfnl @grappler
Add sniff to check for add_..._page() functions + unit tests.
0984dbd 
Closes #11.
jrfnl added a commit that referenced this issue Jul 14, 2016
@jrfnl
Add sniff to check for add_..._page() functions + unit tests.
4a01fbf 
Closes #11.
grappler pushed a commit that referenced this issue Jul 28, 2016
@jrfnl @grappler
Add sniff to check for add_..._page() functions + unit tests.
520bef8 
Closes #11.
grappler pushed a commit that referenced this issue Sep 27, 2016
@jrfnl @grappler
Add sniff to check for add_..._page() functions + unit tests.
e14767f 
Closes #11.
@grappler grappler mentioned this issue Dec 10, 2016
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved / in handbook issue: has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrfnl