Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing new CRater attributes #34

Closed
hirokiterashima opened this issue Sep 9, 2021 · 1 comment · Fixed by #36
Closed

Add support for parsing new CRater attributes #34

hirokiterashima opened this issue Sep 9, 2021 · 1 comment · Fixed by #36
Assignees

Comments

@hirokiterashima
Copy link
Member

CRater will add

  • score_range_min and score_range_max to the score element
  • idea element inside feedback > ideas > idea

Here is the updated response XML:

<crater-results> 
   ...
    <items>
        <item id="...">
            <responses>
                <response ...>
                    <scores>
                        <score ...
                                      score_range_min="1"
                                      score_range_max="5"
                               />
                        <score ...
                                      score_range_min="1"
                                      score_range_max="5"
                               />
                        <score ...
                                      score_range_min="1"
                                      score_range_max="5"
                               />                              
                    </scores>
                    ...
                <feedback>
                  <ideas>
                    <idea name="idea_name_1" detected="1" character_offsets="[]" />
                    <idea name="idea_name_2" detected="0" character_offsets="[]" />
                  </ideas>
                </feedback>
                </response>
            </responses>
        </item>
    </items>
</crater-results>

Update the parser to look for these additional fields. Existing CRater items that do not have these new fields should continue to work.

@hirokiterashima hirokiterashima self-assigned this Sep 9, 2021
geoffreykwan pushed a commit that referenced this issue Sep 27, 2021
* Added parser for additional attributes. #34

* Detect ideas in singe score items #34
@geoffreykwan
Copy link
Member

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants