Detect ideas in singe score items #34

WISE-Community · Sep 20, 2021 · c85cc3c · c85cc3c
1 parent 4cdd5e2
commit c85cc3c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/main/java/org/wise/vle/web/CRaterController.java b/src/main/java/org/wise/vle/web/CRaterController.java
@@ -54,8 +54,8 @@ HashMap<String, Object> scoreItem(@RequestBody CRaterScoringRequest request) {
       response.put("score", cRaterResponse.getScore());
     } else {
       response.put("scores", cRaterResponse.getScores());
-      response.put("ideas", cRaterResponse.getIdeas());
     }
+    response.put("ideas", cRaterResponse.getIdeas());
     response.put("cRaterResponse", cRaterResponse.getResponse());
     return response;
   }

diff --git a/src/test/java/org/wise/vle/web/CRaterControllerTest.java b/src/test/java/org/wise/vle/web/CRaterControllerTest.java
@@ -68,12 +68,15 @@ public void verifyItemId_InvalidId_ReturnFalse() {
   }
 
   @Test
-  public void scoreItem_SingleScoreItem_ReturnScore() {
+  @SuppressWarnings("unchecked")
+  public void scoreItem_SingleScoreItem_ReturnScoreAndIdeas() {
     CRaterScoringRequest request = new CRaterScoringRequest();
     String cRaterXmlResponse = "<crater-results><tracking id=\"1767940\" />" +
         "<client id=\"WISETEST2\"/><items><item id=\"GREENROOF-II\" ><responses>" +
         "<response id=\"12345\" score=\"1\" realNumberScore=\"1.1138\" confidenceMeasure=\"0.99\" >" +
-        "<advisorylist><advisorycode>0</advisorycode></advisorylist></response>" +
+        "<advisorylist><advisorycode>0</advisorycode></advisorylist><feedback><ideas>" +
+        "<idea name=\"idea1\" detected=\"1\" character_offsets=\"[]\" />" +
+        "</ideas></feedback></response>" +
         "</responses></item></items></crater-results>";
     CRaterScoringResponse cRaterResponse = new CRaterScoringResponse(cRaterXmlResponse);
     expect(CRaterHttpClient.getScoringResponse(request)).andReturn(cRaterResponse);
@@ -83,6 +86,10 @@ public void scoreItem_SingleScoreItem_ReturnScore() {
     assertTrue(scoreItemResponse.containsKey("score"));
     assertEquals(1, scoreItemResponse.get("score"));
     assertEquals(cRaterXmlResponse, scoreItemResponse.get("cRaterResponse"));
+    assertTrue(scoreItemResponse.containsKey("ideas"));
+    List<CRaterIdea> ideas = (List<CRaterIdea>) scoreItemResponse.get("ideas");
+    assertEquals(1, ideas.size());
+    assertTrue(ideas.get(0).isDetected());
   }
 
   @Test