Rewrite specification with algorithms and expanded examples #105
Conversation
This change is a large rewrite of the Serial API with some notable changes: * The specification is renamed to the Web Serial API. * All interface attributes and methods have algorithmic steps. * Examples from the explainer have been integrated. * The Security and Privacy considerations sections have been expanded.
There was a problem hiding this comment.
This is looking great!
Keep in mind that for several patterns I only commented on the first instance of them, e.g. task queuing tweaks.
To summarize the potentially-substantive issues:
-
There's an implicit storage mechanism for "available serial ports on the system which the user has allowed the site to access", which is underspecified and raises a good number of questions.
-
You seem to be defining a lot of new exception types. We generally avoid that, and doing so usually requires coordinating with Web IDL. Maybe it shouldn't, though?
|
I've pushed changes to this branch which I believe resolve most of your comments. Notably what is left to do is specify a storage mechanism for permissions and submit a PR to WebIDL to define the new DOMException types I use. I will be taking time off for next week so take your time reviewing these changes. |
|
Also, it's worth going through the issue tracker after merging this and closing the issues which it fixes, e.g. #87. |
This change is a large rewrite of the Serial API with some notable
changes: