Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 1 Uses Wrong SerialOptions object #82

Closed
odejesush opened this issue Apr 6, 2020 · 2 comments
Closed

Example 1 Uses Wrong SerialOptions object #82

odejesush opened this issue Apr 6, 2020 · 2 comments

Comments

@odejesush
Copy link

The first example, Requesting an Arduino device, is creating a SerialOptions object with a filters property. However, the IDL for SerialOptions does not have this property. The example should be updated to reflect the current shape of the dictionary to prevent confusion. This was pointed out in Issue 1067579.
@bus710
Copy link

bus710 commented Apr 17, 2020

Same here.
I am using Chrome 81.0.4044.92 on Ubuntu x64.
Unlike the document, requestPort accepts serialport options not filter options.

@reillyeon
Copy link
Collaborator

This was fixed by #105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reillyeon @bus710 @odejesush