Add overflow: hidden and user-modify: none to inert style
#33
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -633,6 +633,8 @@ function addInertStyle(node) { | |
| " -webkit-user-select: none;\n" + | ||
| " -moz-user-select: none;\n" + | ||
| " -ms-user-select: none;\n" + | ||
| " overflow: hidden !important;\n" + | ||
| " user-modify: none !important;\n" + | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. Ah, thanks! Changed to |
||
| "}\n"; | ||
| node.appendChild(style); | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces a repaint; currently we have other css properties that are causing a repaint as well (see #21), but those are bugs on the browsers.
Also, on windows this will cause a scrollbar to disappear/appear, causing resizing of the content (change the layout of the content/text), and loose the scroll position.
I'm not sure on this one, @robdodson @alice WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does cause a repaint, but only once per inert root, rather than once per element inside the inert root.
The Windows issue is trickier, though. It seems like there's no good solution here currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible horrible idea that might not work...
Since you only need the overflow rule for Firefox, could you tuck it into a
@supportsblock to limit the damage?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that doesn't help the Windows issue though :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So where are we on this? How much of a deal breaker is the scrollbar thing compared to leaving things focusable? Do we have any other options besides those two?