Add overflow: hidden and user-modify: none to inert style
#33
Conversation
|
@robdodson @valdrinkoshi PTAL? |
|
LGTM. @valdrinkoshi wdyt? |
| @@ -633,6 +633,8 @@ function addInertStyle(node) { | |||
| " -webkit-user-select: none;\n" + | |||
| " -moz-user-select: none;\n" + | |||
| " -ms-user-select: none;\n" + | |||
| " overflow: hidden !important;\n" + | |||
| " user-modify: none !important;\n" + | |||
There was a problem hiding this comment.
none is not a valid type for user-modify https://www.w3.org/TR/1999/WD-css3-userint-19990916#user-modify
Also, it should have the -moz & -webkit prefix https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-user-modify
There was a problem hiding this comment.
Ah, thanks! Changed to read-only and added -moz and -webkit versions.
| @@ -633,6 +633,8 @@ function addInertStyle(node) { | |||
| " -webkit-user-select: none;\n" + | |||
| " -moz-user-select: none;\n" + | |||
| " -ms-user-select: none;\n" + | |||
| " overflow: hidden !important;\n" + | |||
There was a problem hiding this comment.
This forces a repaint; currently we have other css properties that are causing a repaint as well (see #21), but those are bugs on the browsers.
Also, on windows this will cause a scrollbar to disappear/appear, causing resizing of the content (change the layout of the content/text), and loose the scroll position.
I'm not sure on this one, @robdodson @alice WDYT?
There was a problem hiding this comment.
It does cause a repaint, but only once per inert root, rather than once per element inside the inert root.
The Windows issue is trickier, though. It seems like there's no good solution here currently.
There was a problem hiding this comment.
Possible horrible idea that might not work...
Since you only need the overflow rule for Firefox, could you tuck it into a @supports block to limit the damage?
@supports (--moz-user-select: none) {
[inert], [inert] * {
overflow: hidden !important;
}
}
There was a problem hiding this comment.
Oh that doesn't help the Windows issue though :P
There was a problem hiding this comment.
So where are we on this? How much of a deal breaker is the scrollbar thing compared to leaving things focusable? Do we have any other options besides those two?
Fixes #31