Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

add stop propagation on picker element #51

Closed
hi-reeve opened this issue Nov 26, 2021 · 6 comments
Closed

add stop propagation on picker element #51

hi-reeve opened this issue Nov 26, 2021 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@hi-reeve
Copy link

Describe the bug
if the calendar component place inside a popup with behaviour click outside the popup. the picker will autoclose the popup without selecting any value.

To Reproduce
Steps to reproduce the behavior:

  1. Create a popup component (modal)
  2. make the modal have behaviour on autoclosing if click outside the modal
  3. put the datepicker component inside the modal
  4. open the datepicker and click on the picker
  5. See error

Expected behavior
should not closing the picker and modal, maybe add event stop propagation on the picker element?

@Jasenkoo
Copy link
Contributor

What version are you using, this should be fixed, and did you create a custom popup or from some CSS framework?

@hi-reeve
Copy link
Author

What version are you using, this should be fixed, and did you create a custom popup or from some CSS framework?

using the latest version. im creating a custom popup and not using any framework.

@Jasenkoo
Copy link
Contributor

Hmm, can you provide some demo code that I can look into, also, if you use some click outside directive, that can cause it to leave, you can try changing the teleport target to the modal body instead of the document body and see if that fixes the issue

@Jasenkoo Jasenkoo added the question Further information is requested label Nov 26, 2021
@hi-reeve
Copy link
Author

Hmm, can you provide some demo code that I can look into, also, if you use some click outside directive, that can cause it to leave, you can try changing the teleport target to the modal body instead of the document body and see if that fixes the issue

here is the reproduction link.
https://stackblitz.com/edit/vitejs-vite-xcb4vn?file=src/components/Popup.vue

@Jasenkoo
Copy link
Contributor

Tnx, will fix check it

@Jasenkoo Jasenkoo added bug Something isn't working and removed question Further information is requested labels Nov 27, 2021
@Jasenkoo Jasenkoo added this to the v2.4.0 milestone Nov 30, 2021
@Jasenkoo
Copy link
Contributor

Version 2.4.0 is now live with included fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants