Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click event propagation #556

Closed
dev387 opened this issue Sep 4, 2023 · 1 comment
Closed

Click event propagation #556

dev387 opened this issue Sep 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dev387
Copy link
Contributor

dev387 commented Sep 4, 2023

Describe the bug
In our intern application, we have some kind of user inactivity logic which is based on click and touch events. In vue-datepicker library, almost every click event is followed by stop propagation. Maybe there are cases where stop propagation is needed, but I have tried to removing it and it looks that it not break anything. If you want, I can make a PR.

To Reproduce
Steps to reproduce the behavior:

  1. Click on whatever on datepicker '....'
  2. Click event is not propagated

Expected behavior
Click event is propagated to parent element.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop & mobile (please complete the following information):

  • Browser: every browser
  • Library version: Probably all versions, but for now let's say 6.0.0
@dev387 dev387 added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels Sep 4, 2023
@Jasenkoo
Copy link
Contributor

Jasenkoo commented Sep 4, 2023

Initially, it was added here(link to an old repo). I'll probably add a prop to disable these events without the need to remove them completely as it might break existing functionalities with 3rd party libraries, but will see exactly.

@Jasenkoo Jasenkoo added enhancement New feature or request and removed bug Something isn't working awaiting triage The issue is not reviewed by the maintainers labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants