Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paho failing tests #174

Merged
merged 12 commits into from
Apr 14, 2020
Merged

Fix paho failing tests #174

merged 12 commits into from
Apr 14, 2020

Conversation

troian
Copy link
Member

@troian troian commented Apr 14, 2020

No description provided.

troian added 12 commits April 13, 2020 14:23
Handles case when Disconnect from client provides SessionExpiryInterval

Signed-off-by: Artur Troian <[email protected]>
Signed-off-by: Artur Troian <[email protected]>
Prevents double checking for ACL

Signed-off-by: Artur Troian <[email protected]>
Shutdown subscriber when session expire fired.
Prevents subscriber from leaking.

Refactor message publish and ACL

Signed-off-by: Artur Troian <[email protected]>
Signed-off-by: Artur Troian <[email protected]>
1. fix return of granted QoS
2. send disconnect from connection close stage 2 only
3. clone PUBLISH packet before sending from topic manager

Signed-off-by: Artur Troian <[email protected]>
handle flow control as per spec

Signed-off-by: Artur Troian <[email protected]>
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #174 into master will decrease coverage by 0.20%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   50.70%   50.49%   -0.21%     
==========================================
  Files          11       11              
  Lines         994     1002       +8     
==========================================
+ Hits          504      506       +2     
- Misses        451      455       +4     
- Partials       39       41       +2     
Impacted Files Coverage Δ
subscriber/subscriber.go 0.00% <0.00%> (ø)
topics/memlockfree/topics.go 43.25% <27.27%> (-0.86%) ⬇️
topics/memlockfree/node.go 81.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e1126...9ead198. Read the comment docs.

@troian troian merged commit 3e00ff1 into master Apr 14, 2020
@troian troian deleted the fix-paho-failing-tests branch April 14, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant