Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber is leaking if session has expiry #173

Closed
troian opened this issue Apr 14, 2020 · 0 comments
Closed

subscriber is leaking if session has expiry #173

troian opened this issue Apr 14, 2020 · 0 comments
Assignees
Labels

Comments

@troian
Copy link
Member

troian commented Apr 14, 2020

The expiry timer does not shut down the subscriber when the session expiry occurs.
If such leaked subscriber has active subscriptions it keeps persisting messages when clean session arrives.

@troian troian added the bug label Apr 14, 2020
@troian troian self-assigned this Apr 14, 2020
troian added a commit that referenced this issue Apr 14, 2020
Shutdown subscriber when session expire fired.
Prevents subscriber from leaking.

Refactor message publish and ACL

Signed-off-by: Artur Troian <[email protected]>
troian added a commit that referenced this issue Apr 14, 2020
fix: SignalDisconnect before SignalOffline
Handles case when Disconnect from client provides SessionExpiryInterval

fix: tag name for RetainAvailable parameter
fix: send the username to ACL on publish
refactor: check for topic alias when the packet arrived
  prevent double-checking for ACL
refactor: decrement children count on node delete
refactor: set publish stub before unsubscribing
fix: fix to #173
  Shutdown subscriber when the session expire fired.
  Prevents subscriber from leaking.
refactor: incoming PUBLISH messages
  handle flow control as per spec

fix: return of granted QoS
refactor: send disconnect from connection close stage 2 only
refactor: clone PUBLISH packet before sending from a topic manager
@troian troian closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant