Refactor/tooltip set by field #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xile611
changed the title
xile611
force-pushed
the
refactor/tooltip-set-by-field
branch
from
51b990a to
44ba42f
Compare
xile611
force-pushed
the
refactor/tooltip-set-by-field
branch
from
8b78d4f to
4120ba1
Compare
xile611
changed the title
xiaoluoHe
reviewed
Oct 10, 2024
xiaoluoHe
previously approved these changes
Oct 10, 2024
zamhown
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
重构内容：
重构前： tooltip之前需要 tooltipPattern 解析 => tooltip Actual 解析 => tooltip attributes 解析，每步解析都有一些默认值处理、合并数据处理、过滤数据处理
重构后： 合并pattern 和 actual 的解析逻辑，统一一步，做好数据解析和过滤
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough