Skip to content

Commit

Permalink
fix: parser of tooltip content
Browse files Browse the repository at this point in the history
  • Loading branch information
xile611 committed Sep 27, 2024
1 parent 765741f commit 51b990a
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions packages/vchart/src/series/base/tooltip-helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type {
ShapeType,
TooltipActiveType,
TooltipData,
TooltipPatternCallback,
TooltipPatternProperty
} from '../../typings';
import { array, isFunction, isValid } from '@visactor/vutils';
Expand Down Expand Up @@ -160,7 +161,7 @@ export class BaseSeriesTooltipHelper implements ISeriesTooltipHelper {
protected getDefaultContentList(
activeType: TooltipActiveType
): MaybeArray<TooltipPatternProperty<MaybeArray<ITooltipLinePattern>>> {
return [{}];
return [this.getDefaultContentPattern(activeType)];
}

protected getContentList(
Expand All @@ -179,12 +180,11 @@ export class BaseSeriesTooltipHelper implements ISeriesTooltipHelper {
params?: TooltipHandlerParams
) {
const titlePattern = isFunction(titleSpec)
? (titleSpec(data, params) as ITooltipLinePattern)
? ((titleSpec as TooltipPatternCallback<ITooltipLinePattern>)(data, params) as ITooltipLinePattern)
: (titleSpec as ITooltipLinePattern);

return titlePattern
? {
...this.getDefaultTitlePattern(activeType),
...titlePattern
}
: this.getDefaultTitlePattern(activeType);
Expand Down Expand Up @@ -212,7 +212,6 @@ export class BaseSeriesTooltipHelper implements ISeriesTooltipHelper {
userContents.forEach(entry => {
content.push({
...shapeAttrs,
...this.getDefaultContentPattern(activeType),
...entry
});
});
Expand All @@ -239,15 +238,15 @@ export class BaseSeriesTooltipHelper implements ISeriesTooltipHelper {
};
}

protected getDefaultTitlePattern(activeType: TooltipActiveType): ITooltipPattern['title'] {
protected getDefaultTitlePattern(activeType: TooltipActiveType): ITooltipLinePattern {
return {
key: undefined,
value: activeType === 'group' ? this.groupTooltipTitleCallback : this.dimensionTooltipTitleCallback,
hasShape: false
};
}

protected getDefaultContentPattern(activeType: TooltipActiveType): ITooltipPattern['content'] {
protected getDefaultContentPattern(activeType: TooltipActiveType): ITooltipLinePattern {
return {
seriesId: this.series.id,
key: activeType === 'group' ? this.groupTooltipKeyCallback : this.markTooltipKeyCallback,
Expand Down

0 comments on commit 51b990a

Please sign in to comment.