Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gh-847: Fixes malformed Kmsi value in form #848

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

dboitnot
Copy link
Contributor

@dboitnot dboitnot commented Jul 9, 2022

Addresses #847 by trimming all Kmsi values and dropping any empty ones.

@mapkon mapkon linked an issue Mar 23, 2023 that may be closed by this pull request
Copy link
Contributor

@mapkon mapkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is fairly straightforward a change. However, that file has zero tests to back it up - what is our confidence level on this?

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Merging #848 (beb29f6) into master (381b1f0) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   32.33%   32.33%           
=======================================
  Files          52       52           
  Lines        7502     7502           
=======================================
  Hits         2426     2426           
  Misses       4753     4753           
  Partials      323      323           
Flag Coverage Δ
unittests 32.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dboitnot
Copy link
Contributor Author

I suppose this is fairly straightforward a change. However, that file has zero tests to back it up - what is our confidence level on this?

All I can say is it definitely solved my problem and I think it makes sense to prune the empty values. To be honest I have not been using this project as my client has switched to AWS SSO.

@mapkon mapkon merged commit fbf6134 into Versent:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle malformed Kmsi form field in ADFS
3 participants