-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle malformed Kmsi form field in ADFS #847
Comments
It turns out that, at least in my case, it's not trailing white space but a second, empty value for len(authForm["Kmsi"]) // == 2 |
dboitnot
added a commit
to dboitnot/saml2aws
that referenced
this issue
Jul 9, 2022
This was referenced Jul 9, 2022
dboitnot
added a commit
to dboitnot/saml2aws
that referenced
this issue
Jul 21, 2022
mapkon
added a commit
to dboitnot/saml2aws
that referenced
this issue
Mar 9, 2023
Just out of curiosity, is that issue also persisting with the version out of #795 ? In that case I would adopt the referenced fix. |
mapkon
added a commit
to dboitnot/saml2aws
that referenced
this issue
Mar 23, 2023
mapkon
added a commit
to dboitnot/saml2aws
that referenced
this issue
Mar 26, 2023
mapkon
added a commit
to dboitnot/saml2aws
that referenced
this issue
Mar 27, 2023
mapkon
added a commit
that referenced
this issue
Mar 27, 2023
fix gh-847: Fixes malformed Kmsi value in form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've encountered a situation where the value for
Kmsi
is "true " (with trailing space). This leads to:Apparently this value is being pulled directly from the server's response:
saml2aws/pkg/provider/adfs/adfs.go
Line 75 in df3f6cf
The text was updated successfully, but these errors were encountered: